mninc / tf2-trade-bot Goto Github PK

1. Ability to manually set currency prices
   Backpack.tf prices for keys are always a little (or a lot, as right now) outdated; suggestions take several days to get accepted and by the time they do the price usually has already changed.

2. Support for 0.05 / craft weapon prices
   Preferably even fractions of a weapon prices like 1/3 of a scrap, 1/5 of a scrap, though this sounds complicated and isn't very important at all because of the low value.

3. Auto-restart
   Occasionally something happens, also currently log spam builds up and doesn't go away until you restart. In either case an option to have it auto-restart every half an hour or something would be nice. Even scrap.tf does it! added

Hi, is this where i report that i am having a problem? anyways thanks so much for making this and making it for free, i just need some help i keep getting a message that says [trading.data]: Unable to find file
I do have a file called trade.data and this is what i have inside:
item market name, ref price, <type (sell/buy)>
the killer exclusive,2,sell
the killer exclusive,1.88,buy
i am probably doing something wrong but help would be appreciated
Also i was getting a message early that my username or password or secrets where no valid, i put that information already, wondering if that has anything to do?
Also there are brackets on ref price and item market name, though it doesn't show so i took them off
Anyways thanks for your time!

Sorry for bad english, not my language.

bug 1.
For some reason sometimes bot rejects trade who have metal change.
For example. Someone is selling to bot item for 10.11 ref. The seller sees that the bot has run out scrap and rec, and instead of 10.11 ref he takes 11 ref, and adds 0.88 ref for his item as change.
In the ordinary situation, this is absolutely good deal and should be accepted. But the bot rejects such a trade as the wrong price.
However, in situations where change only 1 scrap or 1 rec bot accepts. Something is more complicated than this, the bot rejects. I do not know exactly why and how this is happening, but it happens.

bug 2.
Bot does not see a difference between regular trade and 15 days withholding trade. (For new Steam users, who have not installed mobile phone protection.) So the bot accepts any 15 days hold trade who have the right price.
I understand that any profitable trade is a good trade, but in the case of 15 days hold, it is wrong.
For example. I have 100 ref, as a good trader, I can turn these 100 ref into 200 ref less than 3 days. However, if these 100 ref got into 15 days hold trade, I can not do anything, and I can not get any profit. these 100 refs are simply frozen. So the bot should be learned to see the difference between regular trade and 15 days hold trade.
And for users who want to accept such trades, in "settings.json" you can add an option, enable or disable 15 days hold trade. Аnd enable or disable 15 days hold gift trade. In case if someone sends a gift with 15 days hold trade. (sometimes it happens)

bug 3.
Bot does not see a difference between uncraftable and craftable items.
Some uncraftable and craftable items have a big difference in price. And because the bot does not see the difference between them. this can be exploit. someone can buy cheap uncraftable items and sell them to the bot in price as craftable items. Or something similar.
So the bot should be learned to see the difference between uncraftable and craftable items.
And in "trade.csv" user could set a price for uncraftable and craftable items separately.
for example:
\
Backpack Expander, 0.0.16.0.0, buy
Non-Craftable Backpack Expander, 0.0.13.0.0, buy
\
or something similar.

These are all the bugs that I found. I would be happy if they would been fix in the near future. Next will go a Request that I would be happy to see in future bot update. but they are not so important as bugs.

Request 1.
Please add a variable "Do not cancel the trade with unknown items" in "settings.json"
For example. If someone buys a key and put the wrong number of ref or nothing, this obviously should be rejected. But if someone put unknown items? who knows, maybe this is a profitable trade. Of course, trade like this, will have to be checked by the user himself. But, this is better than if the bot will be reject all such a trades. of course this can be turned on or off,

Request 2.
Please add the possibility to set a limit for buying items.
for example. in "trade.csv"
\
Mann Co. Supply Crate Key, 0.0.38.0.0, buy (limit, 10)
\
Where (limit, 10) means that the bot will stop buying these items when their number in the backpack <= 10.
or something similar. limit for sell items, it's necessary.

Request 3.
Please add a trade history. I know that a trade history can be check in Steam. But this section loads forever and super lag. Also the whole trade history is in the "trade.log" but there is literally everything (every bot tick.) after a day of work, i can not even check "trade.log" too much text inside.
It would be nice if the bot recorded all processed trade in a separate text file. When creating a new text file, every time it "bot.py" starts. That would be enough.

Request 4.
Please make a different colors for processing trade in the program console.
When the trade is accepted.
line "Looks good" make green.
When the trade is rejected.
line "Not good" make red.
And When the trade is ignored. (if yu add a variable "Do not cancel the trade with unknown items")
line "Unknown items" make yellow.
I know that this is not important. But it be nice. =)

                                                      From me.

Thanks for creating this bot. I just started learning programming and do not know much. But your bot is the easiest to install and completely cantrols all config. Best bot. I sent a little donate on your Steam. I hope the bot will be evolve and gets better. If so, I will not forget it. Thank you for your time.

Currently, the bot runs a little backwards, what do I mean? Well, it's currently switching the items_to_receive with items_to_give, and trades_received with trades_sent. Why? Because steam was a jerk to me, and messed up the API, and I was getting backward responses. I'm going to set it back to normal, because I think I'm a special case 😉 However, if you had this problem along side me, make sure to comment, and just use the older version of the file. Thanks for using this bot! Love yall :D

trying to start the bot , everytime i get missing token value even though i added the bp.tf token

So, somthing I've been wanting to add is unusual support. At the moment, you can trade unusuals, however, the bot can't distinguish what effect is on it. What can you do? This sounds sketchy, I know, but you could lend me an unusual for a couple of days. I allready have an idea of what to do...

for assetID in self.trade['items_to_receive']:
    for v in self.trade['items_to_receive'][assetID]['descriptions']:
        if v['value'].startswith('★'):
            print("Unusual!")

But I would need to test it. Or, if you have one, and have computer knowledge, you could make a pull request and show me What you've done to make it work! Thanks for using tf2-trade-bot :D