mnthomson / terraform-provider-dominos

🎲🍕 The Terraform plugin for the Dominos Pizza provider

Hey there, I'm Max! 👋

I work on cloud infrastructure, system observability, & automation tooling

I build with this tech

My stats

terraform-provider-dominos's Issues

Terraform v1.3 released

Describe the solution you'd like

Add v1.3.x the TF Provider Test CI job Matrix

Validate string input

Is your feature request related to a problem? Please describe.

Entering a not allowed string is a hassle

Describe the solution you'd like

Use https://github.com/hashicorp/terraform-plugin-framework-validators

Delivery Type

Either Carryout or delivery, Should also include option for delivery tip + note
Related: nat-henderson/terraform-provider-dominos#11

HTTP Client in provider

Is your feature request related to a problem? Please describe.

Throughout the codebase, there are a lot of &http.Client{} calls

Describe the solution you'd like

Create a client in the providerData struct

Validate provider config

Is your feature request related to a problem? Please describe.

If bad data is provided in yhr provider block, it will fail late at the ordering stage

Describe the solution you'd like

Validate the input data

Remove CC input

Domino's supports paying either at the door for pickup or delivery. Storing the CC details in tfstate is dangerous and an unneeded risk
Related: nat-henderson/terraform-provider-dominos#17

Markdown linting

Upgrade to TF Plugin Framework v0.11.1

Upgrade TF Plugin Framework

Describe the solution you'd like

Implement v1.0.1 of the Terraform Plugin Framework

GoReport Card

Describe the solution you'd like

https://goreportcard.com/report/github.com/mnthomson/terraform-provider-dominos

Datasource Address isn't set to api return value

Describe the bug

The Dominos API returns the corrected address, this should be the address stored in state

To Reproduce
Steps to reproduce the behaviour:

1. Run terraform apply
2. Check state file
3. Notice that the value is not set to the API returned value

Expected behaviour

The state file should display the returned canonicalized version

Additional context

Not sure if this would be counter to the whole "IaC" when the value is actually not what is shown/stored as. Might need some input

PR Templates

Issue Templates

Because this is unformatted and looks boring

Custom Pizza datasource

Format Imports

Is your feature request related to a problem? Please describe.

Having local + remote imports in the same list makes them hard to differentiate

Describe the solution you'd like

Run goimports in CI to ensure they are separated

PR title lint

Resource Order doesn't actually order pizza

Describe the bug

The resource_order doesn't order pizza on terraform apply

Expected behaviour

A pizza is ordered

Additional context

Value conversion error: mismatch between struct and object when applying

Describe the bug
Terraform apply fails due to a value conversion error relating to "address_api_object" found in the resourceOrderData struct and the "api_object" variable used by the dominos_order resource.

Likely has to do with this line, but I'm not familiar with Go or how I would go about testing it myself.

To Reproduce
Steps to reproduce the behaviour:

1. Run command terraform apply while there is a dominos_order resource in the plan.

Expected behaviour
Terraform apply succeeds.

Screenshots

Desktop Versions:

• OS: Windows 10
• Terraform Version: 1.5.7

Option for Delivery Instructions

Is your feature request related to a problem? Please describe.

I'd like to add a delivery instruction

Describe the solution you'd like

An optional field in the resource_order object

Bump version with PR tags