mnurzia / even-better-ls Goto Github PK

The current version of coreutils is 8.29, but the version of ls.c provided in this repo is from 8 months ago - coreutils 8.2.
This could potentially cause a lot of problems and potentially make the project uncompilable and buggy.
Trying to port the project to a newer coreutils version (like I tried to do in my fork) introduces a plethora of bugs related to element alignment and filename escaping.

Just wanted to suggest to post this to /r/unixgore, I am sure they would appreciate it. Maybe you could even get top post of all time! 🥇

Auto Suggestions using tab without even-better-ls, working as expected.

Auto Suggestions using tab with even-better-ls, not working as expected. All I am doing is pressing tab.

Hello

I am using Mac OS X 10.12 and iTerm2 as my terminal emulator

Running ls_colors_generator shows the icons as expected, however running the patched ls binary doesn't seem to respect the LS_COLORS variable

The patched ls output is different from the system ls, so I know that this is the binary being used. For clarity, here is an md5 of the file if comparison is needed, not sure what other information you would need to assist with this

 in ~ md5 /Users/ole09/bin/lsi
MD5 (/Users/ole09/bin/lsi) = 6228598ea957078cc985ffb684cc5e9f

Thanks,

Oliver

When using oh-my-zsh auto-completion by pressing TAB key, the suggested file list is glitching when the cursor moves around the list (not exactly sure why).

Simply disable the colors in ls to fix it. In your ~/.zshrc:
DISABLE_LS_COLORS="true"

And it will fix the problem.

In light color schemes, such as Tango, I cannot see the colors of files. It's hardly visible.

Here is the picture of same command under "Tango" (light) and "Solarized Dark" (dark) scheme

Tango

Solarized Dark

Notice that the directory names aren't visible at all!

Interestingly, some of my directories don't properly show up with the directory icon. Running ls -l you can see that the directory "Books and Textbooks" appears as if it is a regular file, even though it has the prefix "d". What could be causing this?

chmod 777 ... leads to security flaw. This value should be changed to 755

It would be great to have a darker color for hidden files, so we can quickly differenciate it.

This is how even-better-ls looks on my machine

As you can see, all of the files are highlighted by a black background.
My background colour is not present in in my palette, is there any way to change files' background colours to the background colour without changing the palette?

make fails with these errors:

1 warning and 4 errors generated.
make[4]: *** [stpncpy.o] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

And afterwards the expected files are not found in src/.

Trying to compile this leaves me with the following:
lib/freadseek.c: In function 'freadptrinc':
lib/freadseek.c:68:3: error: #error "Please port gnulib freadseek.c to your platform! Look at the definition of getc, getc_unlocked on your system, then report this to bug-gnulib."
#error "Please port gnulib freadseek.c to your platform! Look at the definition of getc, getc_unlocked on your system, then report this to bug-gnulib."
^~~~~

I believe we could get more exposure for this project (therefore, more maintainers and bug-fixers) if we publish it to the AUR. I volunteer to try and make an entry and update the project but I'm still quite new at this and would like to consult some guides first.
If anyone else (preferably with more experience with pushing things to the AUR) would like to volunteer and replace me I would be very glad.

I installed it successfully but there is nothing showing in ls.
I also installed it on a server (also Debian) and it works fine there. Both using zsh.

No idea where to start debugging. Perhaps you can point me in the right direction ?

Hi!

I'm trying to compile it in archlinux and I get the following error:

ls.c: In function 'has_capability':
ls.c:2649:3: error: unknown type name 'cap_t'
   cap_t cap_d = cap_get_file (name);

https://github.com/ryanoasis/nerdfonts is broken
update it with https://github.com/ryanoasis/nerd-fonts

The original LS has dir_colors for generating the LS_COLORS attributes, which already supports console escape sequences which permits mapping unicode character sets to file types:

This for example, when the below is added to ~/.dir_colors, it will make all rc resource files light green in appearance and set the alpine linux icon when using NerdFonts:
*rc 36m \e[36

I recommend updating the project/readme with the above details to assist in disseminating this information so that as a community we can focus on improving our file type mappings with contributions to https://github.com/trapd00r/LS_COLORS additional icon/color mappings.

I ran the install cmd from the main page (Ubuntu 18.04), as a normal user (no sudo):

src/ls.c: In function 'print_dir':
src/ls.c:2581:27: error: 'ST_NBLOCKSIZE' undeclared (first use in this function); did you mean 'S_BLKSIZE'?
ST_NBLOCKSIZE, output_block_size);
^~~~~~~~~~~~~
S_BLKSIZE
src/ls.c:2581:27: note: each undeclared identifier is reported only once for each function it appears in
src/ls.c: At top level:
src/ls.c:2665:34: error: expected ';', ',' or ')' before 'ATTRIBUTE_UNUSED'
has_capability (char const *name ATTRIBUTE_UNUSED)
^~~~~~~~~~~~~~~~
src/ls.c: In function 'gobble_file':
src/ls.c:2835:29: warning: implicit declaration of function 'has_capability' [-Wimplicit-function-declaration]
f->has_capability = has_capability (absolute_name);
^~~~~~~~~~~~~~
src/ls.c:2927:16: warning: implicit declaration of function 'ST_NBLOCKS'; did you mean 'FNONBLOCK'? [-Wimplicit-function-declaration]
blocks = ST_NBLOCKS (f->stat);
^~~~~~~~~~
FNONBLOCK
src/ls.c:2932:47: error: 'ST_NBLOCKSIZE' undeclared (first use in this function); did you mean 'S_BLKSIZE'?
ST_NBLOCKSIZE, output_block_size),
^~~~~~~~~~~~~
S_BLKSIZE
src/ls.c: In function 'align_nstrftime':
src/ls.c:3468:48: warning: passing argument 5 of 'nstrftime' makes pointer from integer without a cast [-Wint-conversion]
size_t ret = nstrftime (buf, size, nfmt, tm, __utc, __ns);
^~~~~
In file included from src/ls.c:110:0:
./lib/strftime.h:28:8: note: expected 'timezone_t {aka struct tm_zone *}' but argument is of type 'int'
size_t nstrftime (char *, size_t, char const *, struct tm const *,
^~~~~~~~~
src/ls.c: In function 'print_long_format':
src/ls.c:3671:28: error: 'ST_NBLOCKSIZE' undeclared (first use in this function); did you mean 'S_BLKSIZE'?
ST_NBLOCKSIZE, output_block_size));
^~~~~~~~~~~~~
S_BLKSIZE
src/ls.c: In function 'quote_name':
src/ls.c:3885:21: warning: implicit declaration of function 'DECLARE_ZEROED_AGGREGATE' [-Wimplicit-function-declaration]
DECLARE_ZEROED_AGGREGATE (mbstate_t, mbstate);
^~~~~~~~~~~~~~~~~~~~~~~~
src/ls.c:3885:47: error: expected expression before 'mbstate_t'
DECLARE_ZEROED_AGGREGATE (mbstate_t, mbstate);
^~~~~~~~~
src/ls.c:3892:63: error: 'mbstate' undeclared (first use in this function); did you mean 'mbstate_t'?
bytes = mbrtowc (&wc, p, plimit - p, &mbstate);
^~~~~~~
mbstate_t
src/ls.c: In function 'print_file_name_and_frills':
src/ls.c:4048:31: error: 'ST_NBLOCKSIZE' undeclared (first use in this function); did you mean 'S_BLKSIZE'?
ST_NBLOCKSIZE, output_block_size));
^~~~~~~~~~~~~
S_BLKSIZE
src/ls.c: In function 'length_of_file_name_and_frills':
src/ls.c:4244:64: error: 'ST_NBLOCKSIZE' undeclared (first use in this function); did you mean 'S_BLKSIZE'?
human_output_opts, ST_NBLOCKSIZE,
^~~~~~~~~~~~~
S_BLKSIZE
src/ls.c: In function 'usage':
src/ls.c:4704:7: error: too few arguments to function 'emit_ancillary_info'
emit_ancillary_info ();
^~~~~~~~~~~~~~~~~~~
In file included from src/ls.c:88:0:
src/system.h:630:1: note: declared here
emit_ancillary_info (char const *program)
^~~~~~~~~~~~~~~~~~~
Makefile:9134: recipe for target 'src/ls.o' failed
make[2]: *** [src/ls.o] Error 1
make[2]: Leaving directory '/home/me/coreutils-8.29'
Makefile:11729: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/me/coreutils-8.29'
Makefile:5990: recipe for target 'all' failed
make: *** [all] Error 2
mv: cannot stat 'ls': No such file or directory
mv: cannot stat 'dir': No such file or directory
mv: cannot stat 'vdir': No such file or directory

I really had problems installing even-better-ls, later on I found that this doesn't run on MacOs? Anyway, I ran the following command:

sh -c "$(curl -fsSL https://raw.githubusercontent.com/illinoisjackson/even-better-ls/master/install.sh)"

This really took a while doing a lot of stuff.. I don't get it to work and I don't know how to undo everything it did during install?? My terminal (iTerm2) now hangs a couple of seconds until I drag the terminal window or make another app active.. I don't see any errors or weird things going on in activity window. How to uninstall/undo?

Distribution: Arch

I get this error here when I run
sh -c "$(curl -fsSL https://raw.githubusercontent.com/illinoisjackson/even-better-ls/master/install.sh)"

Hey there,
when I follow your instructions with my xfce4-terminal I get the following output:

 Bilder  connection_test.zip  Dokumente  Downloads  git  Musik  Nextcloud  Öffentlich  Schreibtisch  Videos  vm

Sofar only the icons für .pdf and .iso are working. What am I doing wrong or overseeing here?