moagrius / isonscreen Goto Github PK

Hi,
good work, this plugin!
Question:
What if the element is larger (e.g. higher) than the viewport?
In this case we have the element even more than 100% on screen.
How can that be checked and made to result in "true" with this plugin?
Thank you :)

So I'm using a theme that I believe is using an older version of your code and I'm getting the following error

TypeError: undefined is not an object (evaluating 'bounds.left')

I did a console.log(bounds) and bounds has valid values for left and top. Testing in Chrome and Safari.

$.fn.is_on_screen = function(){

    var win = $(window);

    var viewport = {
        top : win.scrollTop(),
        left : win.scrollLeft()
    };
    viewport.right = viewport.left + win.width();
    viewport.bottom = viewport.top + win.height();

    var bounds = this.offset();
    bounds.right = bounds.left + this.outerWidth();
    bounds.bottom = bounds.top + this.outerHeight();

    return (!(viewport.right < bounds.left || viewport.left > bounds.right || viewport.bottom < bounds.top || viewport.top > bounds.bottom));

};

Hi,

Your script has come in really handy. Thanks.
I need to know what license you distribute the code under to be able to include it in my project but I can't find it.
Do you use a license for this code? It'd be great to have a free one.

Thanks again.
Chris.