mochan42 / ft_irc

Hi there 👋

• I completed my Software Engineering Core Curriculum at 42 Wolfsburg.
  
• I also completed a full time Data Science degree (Master Level) with OpenClassrooms.
  
• I am interested in : Machine Learning, Data Science, Big Data, Computer Vision, Automotive Engineering and Embedded Systems.
  
• 🔭 I’m currently working on : C++
• 🌱 I’m currently learning : C++, Data Science
• 😄 Pronouns: he/him
• The languages I learn : C, C++, Python, Matlab
  
  
• The tool I use to code : Visual Studio Code
  
• The clouds I use to deploy my machine learning models and my dashboards: Azure, AWS
  

🔥 My Stats :

ft_irc's Issues

remChannel() func

When User leaves channel as last user, channel needs to be deleted.

Limitations on password formats?

No limitations

Unit test for createChannel and getChannel

Unit tests are important!

correct project name

Checking that client filles all requirements before joining channels

Find and fix the 4 Errors ("Use of uninitialised value of size 8") upon initialization of the Server

Find and fix the 4 Errors ("Use of uninitialised value of size 8") upon initialization of the Server

segfault when user /join channel or set username without nickname defined with nc (not HexChat)

Need to check if nickname is defined before authorizing to execute /join channel.

open up values for available server port values from 1 to 65535

Florian : port values below 1025 can be used if we run ircserv as super user (sudo)

[Server] Implement verifyPassword() function

In order for the User to access the password of the Server, we need to implement a function which verifies the passwords correctness without exposing it to the User class directly.

/Kick command doesn't recognize channel nor kick message

When we /kick a user, the syntax is not correct.
Examples of /kick command:

However, when we try out this syntax, it tries to interpret the first argument as the user instead of the channel that the user is to be kicked from. Furthermore, the ':' should indicate a kick message.

[Server] Implement createUser() function

Implement createUser() like defined in the Server.hpp file.

Check how to parse MODE command

[Server] initialize User with pointer to Server (*this)

User class needs a reference to the Server it's in. Maybe we can make the Server class a global variable?

Leaks on non-freed but reachable memory after client connected

4 Leaks in code after closing program:

Server needs to send 001 message on connect (Implement in User constructor perhaps)

Remove user.cpp

Remove sunset name of lowercase user.cpp / user.hpp

/Pass has to be first command

/nick when called on nc without second arg segfaults.

prob. same fix as for /user and /pass

Message from nc doesn't get sent to HexChat user when more than 1 arg

Delete the Channel when the last User leave/be kicked/quit.

Find a solution for the Crtl + D input

When the Client sends partial data and then ends the communication by providing an EOF command like in the following example:

/JO CRTL +D
IN

If the command is continued in a new line after having sent the first (partial) command, the Server should be able to connect the dots and recognize the command as /JOIN instead of treating it as 2 seperate messages.

Channel is not deleted if /quit is used an you are the last in the channel.

Free User object if socket disconnects unexpectedly

If the recv() function returns a -1, while we are trying to read from that socket, we can assume the client has disconnected.
Upon disconnect, we should free the memory allocated for that user manually.

NC test for when /User is sent with wrong commands SEGFAULT

when running nc and
try to use '/USER'
we segfault

Exit / Close function for server

We need to be able to terminate the program without memory leaks. Therefore we need a function, that makes sure each and every allocated memory item is freed / deleted.

Segfaults /PASS after user is already regitered

Cmds used:

• valgrind ./ircserv 50000 password
• Client connects
• Manually tried the /PASS command
• Listening Socket successfully set to reusable
  Listening Socket successfully set to non blocking
  Listening Socket sucessfully bound to server port
  Listening Socket started listening to IRC clients...
  User with fd = 4 connected with server.
  New client connected from :127.0.0.1:47786
  IP Address (long) :127.0.0.1
  Stored message from client: CAP LS 302
  NICK Ninjacookie
  USER Ninjacookie 0 * :realname

Parsed command: CAP
Parsed arguments: LS 302
Parsed command: NICK
Parsed arguments: Ninjacookie
Parsed command: USER
Parsed arguments: Ninjacookie 0 * realname
Command: CAP
Parsed arguments: 0- LS1- 302Command: NICK
Parsed arguments: 0- NinjacookieCommand: USER
Parsed arguments: 0- Ninjacookie1- 02- *3- realname
User::executeCommand called with command = CAP
User::executeCommand called with command = NICK
User Ninjacookie not found
User::executeCommand called with command = USER
User::setUserName called. The _UserName is now: Ninjacookie
Stored message from client: PASS

Parsed command: PASS
Parsed arguments:
Command: PASS
Parsed arguments:
User::executeCommand called with command = PASS
==5904== Invalid read of size 8

HEAP SUMMARY:
==5904== in use at exit: 543 bytes in 8 blocks
==5904== total heap usage: 68 allocs, 60 frees, 80,256 bytes allocated
==5904==
==5904== LEAK SUMMARY:
==5904== definitely lost: 0 bytes in 0 blocks
==5904== indirectly lost: 0 bytes in 0 blocks
==5904== possibly lost: 0 bytes in 0 blocks
==5904== still reachable: 543 bytes in 8 blocks
==5904== suppressed: 0 bytes in 0 blocks
==5904== Rerun with --leak-check=full to see details of leaked memory
==5904==
==5904== For lists of detected and suppressed errors, rerun with: -s
==5904== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
Segmentation fault

create Error class

Error during Server deallocation of memory (~Server())

2 Errors, bytes accessed, were freed.

Test issue place holder

Create a small chatbot that can connect to server

Implement createChannel() function

needs implementation.