GithubHelp home page GithubHelp logo

Comments (3)

defunerik avatar defunerik commented on August 25, 2024

Thanks for the quick fix. Would this also not apply to the usage of the Connection header value when testing for "Keep-Alive", also conducted in present code with case sensitivity? Also implied in the language of the original report was that this issue may be more pervasive, since I suspect most clients are quite literal in their interpretation of the http spec, and even if a field is case insensitive, use the values literally cited in the spec. Thus they will tend to work wonderfully with case sensitive matches.

Other cases that I've found in a quick perusal of the uses of get_header_value:

mochiweb.erl, in body_length/0, value of transfer-encoding tested against "chunked" should be case insensitive
.., function stream_body/4, value of expect header should be case insensitive for 100-continue and other unquoted tokens

That said would you like to me to continue scanning through to find other cases, if any, or just leave it that the issue is to find all cases where there should be a case insensitive comparison?

from mochiweb.

etrepum avatar etrepum commented on August 25, 2024

Well nobody has ever reported a case where that matters, so I'm not inclined to go fix them all myself. You're welcome to find more them and submit a pull request that tests for it and fixes them.

from mochiweb.

defunerik avatar defunerik commented on August 25, 2024

Fair enough, thanks.

from mochiweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.