GithubHelp home page GithubHelp logo

modality / charred-black Goto Github PK

View Code? Open in Web Editor NEW
27.0 27.0 18.0 696 KB

The unofficial, online, Burning Wheel Gold character burner – http://charred-black.herokuapp.com

License: GNU General Public License v3.0

Dockerfile 0.10% Ruby 6.11% CSS 0.64% JavaScript 78.36% HTML 14.78%

charred-black's People

Contributors

modality avatar silverwizard avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

charred-black's Issues

Adding wizard lifepath leads needs to deal with missing leads/key_leads

This fix is needed because leads for Evil Necromancer will be broken otherwise (it will end up as "key_leads": true, "leads": true).

man[man_set][man_lp]['key_leads'] |= [wiz_set]
man[man_set][man_lp]['leads'] |= [leads_short[wiz_set]]

should be (something like) this:

                man[man_set][man_lp]['key_leads'] = man[man_set][man_lp]['key_leads'] || []
                man[man_set][man_lp]['key_leads'] |= [wiz_set]
                man[man_set][man_lp]['leads'] = man[man_set][man_lp]['leads'] || []
                man[man_set][man_lp]['leads'] |= [leads_short[wiz_set]]

``https://charred-black.herokuapp.com/#/`` is broken.

https://charred-black.herokuapp.com/#/ seem to be broken. When is visit the website i can't interact with anything this is what it looks like.
image

Console output looks like this:

Uncaught TypeError: Cannot read property 'innerHTML' of undefined
    at handleIframeLoad (burning.js:14)
    at HTMLIFrameElement.onload ((index):44)
burning-service.js:224 Loaded saved character names
burning-service.js:326 Loaded man starting stat points. 
burning-service.js:345 Loaded man resources. 
burning-service.js:326 Loaded dwarf starting stat points. 
burning-service.js:307 Loaded dwarf lifepaths. 1 settings
burning-service.js:326 Loaded elf starting stat points. 
burning-service.js:345 Loaded dwarf resources. 
burning-service.js:307 Loaded elf lifepaths. 2 settings
burning-service.js:326 Loaded orc starting stat points. 
burning-service.js:307 Loaded roden lifepaths. 3 settings
burning-service.js:345 Loaded roden resources. 
burning-service.js:307 Loaded orc lifepaths. 4 settings
burning-service.js:326 Loaded wolf starting stat points. 
burning-service.js:307 Loaded wolf lifepaths. 5 settings
burning-service.js:345 Loaded elf resources. 
burning-service.js:345 Loaded wolf resources. 
burning-service.js:345 Loaded orc resources. 
burning-service.js:345 Loaded troll resources. 
burning-service.js:307 Loaded troll lifepaths. 6 settings
burning-service.js:326 Loaded troll starting stat points. 
/favicon.ico:1 Failed to load resource: the server responded with a status of 404 (Not Found)
burning-service.js:364 Loaded skills. 
burning-service.js:311 Error: Getting man lifepaths from server failed: HTTP code 0: null
burning-service.js:330 Error: Getting roden stat points from server failed: HTTP code 0: null
angular.min.js:89 TypeError: Cannot read property '(Select Setting)' of undefined
    at calculateCurrentSettingLifepathNames (burning.js:2003)
    at a.BurningCtrl.$scope.onSettingChange (burning.js:385)
    at onLifepathsLoad (burning.js:1902)
    at c.onAllDatasetsLoaded (burning.js:407)
    at c.BurningDataService.datasetLoaded (burning-service.js:286)
    at burning-service.js:379
    at angular.min.js:71
    at F (angular.min.js:97)
    at F (angular.min.js:97)
    at F (angular.min.js:97)
(anonymous) @ angular.min.js:89
angular.min.js:89 TypeError: Cannot read property '(Select Setting)' of undefined
    at calculateCurrentSettingLifepathNames (https://charred-black.herokuapp.com/js/burning.js:2003:62)
    at a.BurningCtrl.$scope.onSettingChange (https://charred-black.herokuapp.com/js/burning.js:385:5)
    at onLifepathsLoad (https://charred-black.herokuapp.com/js/burning.js:1902:10)
    at https://charred-black.herokuapp.com/js/burning.js:407:5
    at c.BurningDataService.registerOnAllDatasetsLoaded (https://charred-black.herokuapp.com/js/burning-service.js:278:7)
    at c.BurningCtrl (https://charred-black.herokuapp.com/js/burning.js:406:15)
    at d (https://charred-black.herokuapp.com/js/angular.min.js:34:265)
    at Object.instantiate (https://charred-black.herokuapp.com/js/angular.min.js:34:394)
    at https://charred-black.herokuapp.com/js/angular.min.js:66:112
    at link (https://charred-black.herokuapp.com/js/angular-route.js:913:26) <div ng-view="" class="ng-scope">
(anonymous) @ angular.min.js:89
/#/:1 [DOM] Found 2 elements with non-unique id #cost: (More info: https://goo.gl/9p2vKq) <input class=​"form-control" id=​"cost" ng-model=​"currentGearCost" placeholder=​"Enter cost in rps" type=​"text">​ <input class=​"form-control" id=​"cost" ng-model=​"currentPropertyCost" placeholder=​"Enter cost in rps" type=​"text">​
/#/:1 [DOM] Found 4 elements with non-unique id #name: (More info: https://goo.gl/9p2vKq) <input class=​"form-control" id=​"name" ng-model=​"name" type=​"text">​ <input class=​"form-control" id=​"name" ng-model=​"currentGearDesc" placeholder=​"Enter name/​description" type=​"text">​ <input class=​"form-control" id=​"name" ng-model=​"currentPropertyDesc" placeholder=​"Enter name/​description" type=​"text">​ <input class=​"form-control" id=​"name" ng-model=​"currentRelationshipDesc" placeholder=​"Enter description" type=​"text">​
DevTools failed to load source map: Could not load content for https://charred-black.herokuapp.com/js/angular.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

This also happens on my phone.

Pretty-print JSON in .char files

The JSON in the .char files is written as a single line, unlike Charred which writes the contents of the .char files as formatted ("pretty-printed") JSON.

Demented Inventor

In the Demented Inventor lifepath, the obligatory trait is stated as 'Unhinged', but the Codex says 'Demented'. I can't find Unhinged anywhere, so I assume this is wrong?

Steel "severely wounded" option applicable lifepaths too limited

Currently, the app automatically determines +/- Steel based on previous lifepaths without any customization options. In the book, +Steel is listed for "soldier, knight, bandit, etc.", while -Steel is for "not a soldier". Whether this question gives +Steel or -Steel should be a toggle, since the list of +Steel lifepaths is not fully defined.

Cannot choose husband's lifepath

The human lifepaths Country Wife, Village Wife, and City Wife require the player to choose their husband's lifepath. The wife gets to choose from her husband's skills, and gets some fraction of his skill points and resources. This is currently not modeled in the tool.

Custom wises missing after uploading from a .char file

Note: This bug is also present in Charred

When downloading a character from Charred Black, custom wises are successfully saved to the .char file. However, if I upload that .char file in a new Charred Black page, the custom wise is missing, and any associated skill points spent are now unspent.

To reproduce:

  • Load a new Charred Black page
  • Under Lifepaths, next to Born Peasant, click Add
  • (optional) Under Stats and Attributes, click Distribute
  • Under Skills, in the Add Custom -Wise field, enter "Roman", and click "Add"
  • Above, in the "Shade and Exponent" column for the "Roman-wise" skill, click "+" to open the skill
  • At the top of the page, click Download Character, and save the .char file
  • Open a new Charred Black page
  • Click Upload Character, and upload the saved .char file
  • Expected: The "Roman-wise" skill should appear in the Skills list, with 1 general skill point spent to open it.
    • Observed: The Skills list is empty.

Elements with non-unique ids (#cost and #name)

Note: This issue is also present in Charred

The DevTools console in Chromium warns of non-unique ids for two elements with id="cost", and four elements with id="name". This might not affect core functionality, but these IDs should be de-duplicated anyway.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.