Comments (4)
Please run validate_repo.py
locally before opening a PR. The docs have not yet been updated to reflect this change.
from fmi-cross-check.
Ah okay. I'll do that as soon as the script is finished or the documentation is updated.
We plan to add OMSimulator and OpenModelica to the FMI Cross Check and for that would run parts or all of this repo on our Jenkins machines. But in my opinion the validate_repo.py
script needs to be improved. It is incredible slow, because it is only running on a single thread on a machine with many threads available.
Also I think it would be a good idea to add some more basic options and checks to validate_repo.py
, e.g. only check parts of the repo. There is no need to run the validation on the whole repo, when I only add one specific version of one tool.
Also a check if all files that are needed as displayed in https://github.com/modelica/fmi-cross-check#add-fmus and only those are present. I forgot to add the passed
/failed
files in #106 and you found it (by looking on it?), but a PR should automatically be checked for that.
EDIT: I now measured the time of validate_repo.py
and it is 12m 24s on my machine and could be at 45 seconds for my 16 threads.
from fmi-cross-check.
The CI is currently disabled due to technical issues. Please open a PR if you want to make changes to validate_repo.py
.
from fmi-cross-check.
@t-sommer which issue is dealing with the technical issues?
from fmi-cross-check.
Related Issues (20)
- Clarify the use of ComplianceChecker and FMPy HOT 3
- Exporting tools are missing in tables HOT 1
- Green button missing for ETAS COSYM HOT 1
- Retroactively flagging FMUs as non-compliant HOT 3
- no LICENSE.txt for this repository HOT 8
- Update documentation of check & PR workflow
- Provide information for why an FMU is not compliant with latest rules HOT 6
- Test FMUs with external dependencies HOT 7
- solidThinking_Activate/2020/CVloop/ doesn't comply with the rules for the directory structure HOT 5
- Cross-check results on fmi-standard.org HOT 10
- Add version tags HOT 1
- Reference results of fmi-cross-check/fmus/2.0/me/win64/Test-FMUs/0.0.2/BouncingBall/ HOT 1
- Start FMI 3.0 sandbox HOT 2
- XC self-certification HOT 1
- Remove "hard fees" from XC rules and come up with new proposal for changes
- Include reference FMUs in XC
- How shall we treat tools/libraries supporting FMU import but not beeing a simulator HOT 1
- circle ci fails - ssh passphrase missing HOT 2
- What "system" libraries can be assumed for the Cross Check? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fmi-cross-check.