GithubHelp home page GithubHelp logo

Comments (4)

t-sommer avatar t-sommer commented on July 20, 2024

Please run validate_repo.py locally before opening a PR. The docs have not yet been updated to reflect this change.

from fmi-cross-check.

AnHeuermann avatar AnHeuermann commented on July 20, 2024

Ah okay. I'll do that as soon as the script is finished or the documentation is updated.

We plan to add OMSimulator and OpenModelica to the FMI Cross Check and for that would run parts or all of this repo on our Jenkins machines. But in my opinion the validate_repo.py script needs to be improved. It is incredible slow, because it is only running on a single thread on a machine with many threads available.

Also I think it would be a good idea to add some more basic options and checks to validate_repo.py, e.g. only check parts of the repo. There is no need to run the validation on the whole repo, when I only add one specific version of one tool.
Also a check if all files that are needed as displayed in https://github.com/modelica/fmi-cross-check#add-fmus and only those are present. I forgot to add the passed/failed files in #106 and you found it (by looking on it?), but a PR should automatically be checked for that.

EDIT: I now measured the time of validate_repo.py and it is 12m 24s on my machine and could be at 45 seconds for my 16 threads.

from fmi-cross-check.

t-sommer avatar t-sommer commented on July 20, 2024

The CI is currently disabled due to technical issues. Please open a PR if you want to make changes to validate_repo.py.

from fmi-cross-check.

lochel avatar lochel commented on July 20, 2024

@t-sommer which issue is dealing with the technical issues?

from fmi-cross-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.