GithubHelp home page GithubHelp logo

Comments (6)

andreas-junghanns avatar andreas-junghanns commented on July 2, 2024 1

Often there are multiple reasons, I suggest to use one line per reason.
Let´s also try to find a "standard" way to describe this so we can grep/find for specific FMUs failing for the same reason.

from fmi-cross-check.

t-sommer avatar t-sommer commented on July 2, 2024 1

You can validate the FMU with FMPy or use the online FMU Check to get a list of all problems.

from fmi-cross-check.

andreas-junghanns avatar andreas-junghanns commented on July 2, 2024

Many FMUs are marked as notCompliantWithLatestRules, but none of them seem to have any information explaining why they are not compliant. It would be good to put a reason for why a certain model is not compliant into the notCompliantWithLatestRules file.

This would have been good to do from the start.
Are you volunteering to do the work now?

from fmi-cross-check.

lochel avatar lochel commented on July 2, 2024

I don't know why all the FMUs are flagged as invalid. I guess the people who where involved should try to recall and provide the information. What I can do is to include a reason for all FMUs that I myself identify as invalid.

from fmi-cross-check.

lochel avatar lochel commented on July 2, 2024

@t-sommer Please explain why you closed the issue. I cannot see that the issue got solved or addressed in any way.

If I understand you correctly, then you are saying that the validation for the fmi cross-check examples is done by a single vendor implementation. This is very odd and I am very surprised that the MA is supporting this approach. It is certainly fine to use certain implementations in the validation process, but the final decision and explanations have to be made manually for the examples in this repository.

from fmi-cross-check.

chrbertsch avatar chrbertsch commented on July 2, 2024

I agree that it would be nice-to-have to directly see the reason for non-compliance in the file, and this is a possible future extension.

But: until now there was no real need for this, as (all of?) the non-compatibilities were found by the validation with fmpy, which also provides a meaningful error message, which can be reproduced by everyone.
And if there was a new finding, as with yours, fmpy was quickly (!) updated, see e.g., CATIA-Systems/FMPy#280 (comment) for your finding.
fmpy is open source, very actively developed and free for inspection, and one of the FMU checkers listed on the FMI website https://fmi-standard.org/downloads/. Its use in the validation within the cross check has been very beneficial and is transparent to everyone, see https://github.com/modelica/fmi-cross-check/blob/master/README.md#validate-the-files.

from fmi-cross-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.