moerill / emojule Goto Github PK

Describe the bug
When writing a timestamp in journal log this module is interpreting this as a potential emoji. Thus trying to display an image when it should not.

Console Errors
No

To Reproduce
Steps to reproduce the behavior:

1. Create a journal note
2. Add a timestamp string
3. Save
4. You'll get a weird "un" or broken image

Expected behavior
No attempt to interpret this timestamp as an image

Screenshots/GIFs/Videos

Desktop (please complete the following information):

• OS: Windows
• Browser Chrome
• FVTT Version 0.7.9
• Module version latest

Using the template
Choose a fitting title to your issue.
Please go through each section, adding as much detailed information as possible and remove the default text. If a section is completly irrelevant for some reason, delete it completly.
Also ideally be somewhat responsive in this issues thread so you can answer possible questions i have.

Describe the bug
https://i.imgur.com/jgYSq4a.png Emojule is, following a functionality overhaul in the pf2e system, reading the content of the @check functions as emojis due to the colons in them.
`

Frequency once per round

Requirements the Runic Warrior is wielding a melee weapon.

The Runic Warrior carves a rune into their air temporarily bespelling their weapon with a fraction of the rune's power. Choose a type of energy: acid, cold, electricity, fire or sonic, the Runic Warrior makes a @check[type:arcana|dc:@self.level|adjustment:-2] check against an easy DC for their level with the following effects. 

Console Errors
none

To Reproduce
Steps to reproduce the behavior:

1. Start a PF2e world. Enable Emojule.
2. Search for a monster using @check in the bestiary browser; "City Guard Squadron" is an easy one to grab. Both the Fire Crossbows! and Lower Halberds! abilities have this.
3. Open the ability. If Emojule is enabled, it will be broken.

Expected behavior
https://i.imgur.com/4IW9nRx.png This is the correct @check button (the "DC Basic Reflex")
Other Modules
Happens only with Emojule enabled, including when it is the only active module.

Screenshots/GIFs/Videos
above

Desktop (please complete the following information):

• OS: W10
• Foundry client
• FVTT Version v9
• Module version 0.3.3
• PF2e 3.10.3

Additional context
Add any other context about the problem here.

Similarly to Discord and other messaging apps, when the message contains only emojis (and in most cases, under a certain threshold), the emotes are shown enlarged instead of text sized.

cause.. why not? :D

First of all, love your work here. Been wanting this one for a while.
I would adore it doubly as much if it had an editor for adding custom emoji as well, simlarly to Discord's per-server system (except without having to pay Tencent for the privilege of using GIFs etc).

Describe the Bug
The custom emoji list will constantly clear itself after emojis are added, becoming completely empty.

To Reproduce
Steps to reproduce the behavior:

1. Create a fresh world.
2. Enable the Emojule module.
3. Go to Configure Settings and open the Custom Emoji Configurator.
4. Add any amount of custom emojis (the custom emojis will work while the Custom Emoji Configurator is open)
5. Press Close and Save Changes. The custom emoji list seems to clear itself after some time, sometimes on refresh, or when you open the Custom Emoji Configurator again. I can't figure out whether there is a consistent trigger here (so it could be a false correlation) but it eventually clears itself.

Module Incompatibilities
I'm using Forge VTT to host my server which has a Forge module built in, but I doubt it's the problem since I replicated the bug on the Standalone Virtual Tabletop Application, as shown below.

Screenshot

Expected Behavior
The custom emoji list should remain unchanged until you edit it again. Additionally, my players weren't able to use custom emojis that I added even when I could, but I'm not sure whether that's intended.

Desktop

• OS: Windows 10 Home (Version 1909) (OS Build 18363.1016)
• Browser: Google Chrome
• FVTT Version: 0.6.6
• Module Version: 0.3.0
• 5e System Version: 0.96

To get rid of the warning of a supposed compatibility risk (currently 0.8.5).