mohittahiliani / ns-3-python-examples Goto Github PK

In the example, the main function takes an argument argv, to which sys.argv is passed during runtime. However the argv variable is never used in the program and the cmd.Parse is again supplied with sys.argv itself.

I feel this would be confusing to a user reading the code.

Suggestions:

1. Remove the argv option from main. import sys globally on top. Call cmd.Parse with sys.argv.
2. Call cmd.Parse with argv.

I feel Option 2 would make the program much more readable.

SetFill method accepts "four" arguments in C++ (e.g., examples/udp/udp-echo.cc, line #134), but does not accept more than "three" in Python (see udp/udp-echo.py, line #130 in this repo)

While porting examples/tcp/star.cc to star.py, it was observed that star.cc does not require a "Simulator::Stop" for termination, whereas star.py does require. The reason is not yet clear.

TCP throughput of the following two programs does not match with that of corresponding C++ programs:

1. ht-wifi-network.py
2. vht-wifi-network.py

Run these programs and corresponding C++ programs with --udp=False to see the difference.