mohsenoid / marvel Goto Github PK

Hi, really nice App architecture. I've a question, why didn't you wrap the database related operations within a rx.Observable?

I mean, for example in the SearchFragment you called the Presenter's loadCharactersCachedData() method, which later calls the DatabaseHelper's selectAllCharacters() method, which runs on the UI thread, should that kind of operations run on a background thread wrapped inside a rx.Observable?

Same thing with the Presenter's doSearch() method, in that case you wrapped the operation in a rx.Observable but you made it run over AndroidScheduler.mainThread(), shouldn't run over some other background thread such as Scheduler.io()?

https://github.com/mmirhoseini/marvel/blob/master/app/src/main/java/com/mirhoseini/marvel/activity/MainActivity.java#L39

Why do injecting context into the context?

When I tried to sync my project after configure all my grades files I have this error:

Error:Execution failed for task ‘:marvel-app:processMockDebugGoogleServices’.

No matching client found for package name ‘test.marvel.debug’

I don’t know if I need to configure something on developers.google.com

I’m seeing that your google-service.json has this part that I don’t have

"client_info": {
  "mobilesdk_app_id": "1:917870933295:android:f40c157f10d0958b",
  "android_client_info": {
    "package_name": "com.mirhoseini.marvel.debug"
  }
}

Edit

To hide the error I added your id's. This part of the code I added to my project :(

{
      "client_info": {
        "mobilesdk_app_id": "1:917870933295:android:f40c157f10d0958b",
        "android_client_info": {
          "package_name": "com.mirhoseini.marvel.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "917870933295-657emgd5pnl2j8lpkfk87unefkub69ol.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyBdbZt2_S2y2-jYVn7xfeyAwMAN7ePfTD0"
        }
      ],
      "services": {
        "analytics_service": {
          "status": 1
        },
        "appinvite_service": {
          "status": 1,
          "other_platform_oauth_client": []
        },
        "ads_service": {
          "status": 2
        }
      }
    }