Working with Redis cluster about ratelimitj

[mokies]

Thanks @Meyy-DL I will definitely take a look and merge it into master. Apologies that I haven't got around to support this yet.

[mokies]

Redis Cluster support is looking good, see 3b2c0cb
Will be included in the 0.5.0 release.

[mokies]

In theory LUA script can work on a Redis cluster. Unfortunately at this time I have not tested the implementation against a Redis cluster.

Take a look http://www.dr-josiah.com/2014/11/introduction-to-rate-limiting-with_26.html under the subtitle 'Generating keys in the script' which discusses the requirements for utilising the LUA script with a Redis Cluster. The Redis implementation is largely based on this excellent blog post from Josiah Carlson.

[danhcc]

@mokies Thank you, I'll see that post.
But I have imported this dependency to my project and I can not run your example because it needs a StatefulRedisConnection but since I'm using Redis cluster so I only have StatefulRedisClusterConnection.
What should I do for now? Should I cast StatefulRedisClusterConnection to StatefulRedisConnection?

[mokies]

@danhcc it looks like we will need to rework some of the interfaces to support a clustered connection. I will give it a shot and get back to you.

[danhcc]

@mokies Thanks in advance

[phrinx]

@mokies we'd also like to use ratelimitj with cluster support so just making you aware that adding this support would be highly appreciated :)

[Meyy-DL]

@mokies I gave a shot to modify the ratelimitj framework to support redis cluster mode for our application and it seems to work fine so far. Would you mind taking a look if I create a pull request?

[shengnian]

1

[mokies]

Apologies for the delay, my day job has been a little full on these past months

@Meyy-DL appreciate the PR.

I am currently working on a change to support a clustered Redis but want to be sure the change has appropriate test coverage before rolling it out.

[Meyy-DL]

@mokies Thank you! Highly appreciate it!

[mokies]

Released https://github.com/mokies/ratelimitj/releases/tag/v0.5.0