moodle-an-hochschulen / moodle-atto_styles Goto Github PK

If is empty "atto_styles | config" crashes javascript, tested in moodle 4.1.1 and atto_styles versión v4.1-r2.

yui_combo.php?m/1688989846/atto_table/button/button-min.js&m/1688989846/atto_clear/button/button-min.js&m/1688989846/atto_undo/button/button-min.js&m/1688989846/atto_accessibilitychecker/button/button-min.js&m/1688989846/atto_accessibilityhelper/button/button-min.js&m/1688989846/atto_wiris/button/button-min.js&3.17.2/promise/promise-min.js&m/1688989846/atto_html/beautify/beautify-min.js&m/1688989846/atto_html/codemirror/codemirror-min.js&m/1688989846/atto_html/button/button-min.js&m/1688989846/atto_morefontcolors/button/button-min.js&m/1688989846/atto_fontfamily/button/button-min.js&m/1688989846/atto_morebackcolors/button/button-min.js&m/1688989846/atto_hr/button/button-min.js&m/1688989846/atto_styles/button/button-min.js&m/1688989846/atto_cloze/button/button-min.js&m/1688989846/atto_emojipicker/button/button-min.js:77 Uncaught TypeError: Cannot read properties of null (reading 'type')
    at YUI.<anonymous> (yui_combo.php?m/1688989846/atto_table/button/button-min.js&m/1688989846/atto_clear/button/button-min.js&m/1688989846/atto_undo/button/button-min.js&m/1688989846/atto_accessibilitychecker/button/button-min.js&m/1688989846/atto_accessibilityhelper/button/button-min.js&m/1688989846/atto_wiris/button/button-min.js&3.17.2/promise/promise-min.js&m/1688989846/atto_html/beautify/beautify-min.js&m/1688989846/atto_html/codemirror/codemirror-min.js&m/1688989846/atto_html/button/button-min.js&m/1688989846/atto_morefontcolors/button/button-min.js&m/1688989846/atto_fontfamily/button/button-min.js&m/1688989846/atto_morebackcolors/button/button-min.js&m/1688989846/atto_hr/button/button-min.js&m/1688989846/atto_styles/button/button-min.js&m/1688989846/atto_cloze/button/button-min.js&m/1688989846/atto_emojipicker/button/button-min.js:77:316)
    at Array.forEach (<anonymous>)
    at m.each.m.forEach (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:10:1339)
    at n.initializer (yui_combo.php?m/1688989846/atto_table/button/button-min.js&m/1688989846/atto_clear/button/button-min.js&m/1688989846/atto_undo/button/button-min.js&m/1688989846/atto_accessibilitychecker/button/button-min.js&m/1688989846/atto_accessibilityhelper/button/button-min.js&m/1688989846/atto_wiris/button/button-min.js&3.17.2/promise/promise-min.js&m/1688989846/atto_html/beautify/beautify-min.js&m/1688989846/atto_html/codemirror/codemirror-min.js&m/1688989846/atto_html/button/button-min.js&m/1688989846/atto_morefontcolors/button/button-min.js&m/1688989846/atto_fontfamily/button/button-min.js&m/1688989846/atto_morebackcolors/button/button-min.js&m/1688989846/atto_hr/button/button-min.js&m/1688989846/atto_styles/button/button-min.js&m/1688989846/atto_cloze/button/button-min.js&m/1688989846/atto_emojipicker/button/button-min.js:77:230)
    at n._initHierarchy (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:279:3762)
    at n._baseInit (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:279:1086)
    at n.init (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:311:694)
    at n._initBase (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:279:948)
    at n.v (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:279:95)
    at n.o (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:319:50)

Here is a patch to fix in lib.php
lib.php.patch

I configured a number of CSS styles and passed valid JSON into the configuration textbox, strictly according to the instructions. This JSON worked under Moodle 3.x

With version 4.0-r2 I'm getting this the moment I try to set a style to a paragraph of text:

Hello!
We've been using this plugin and it works perfectly, thank you!! However, I just noticed today that the styles are not showing on Moodle mobile app. It looks plain text, with no colors or anything.
Could anybody help me on this, please?
Thank you!

!

This issue serves as a reminder that this plugin still uses YUI in its JavaScript code.
Currently, I am not aware that you can build atto_* plugins without YUI.
But as soon as Moodle core supports this, this plugin should be adapted.

Running Moodle 3.5 and v3.5-r2 of atto styles. The drop-down menu in the Atto editor does not display a preview of the styles. Instead it displays '</> name of style'.

Has the preview function become deprecated?
I have "preview": "true" set for each style in the Styles settings page. However your example code on that page omits this line.

Hi, the plugin "styles" cannot be used suddenly. How can I solve this issue>

I set up my install with the CSS and styles widget examples provided in the readme (https://github.com/moodleuulm/moodle-atto_styles/blob/master/README.md) with the CSS pasted into Boost Raw initial SCSS (Site Administration-Appearance-Themes-Boost-Advanced settings) and the styles configuration pasted into the styles settings, and I've added Styles to the Atto toolbar. I have also tried pasting CSS into Boost Raw SCSS as well as the other custom CSS areas available within Themes.

However when I try to edit a page and use Styles this is the result I see:

Could you let me know what I may be doing wrong here? Thanks!

Hello!
Are there any plans to port or develop the plugin for the tiny editor?

Hi,
We love this plugin but we are having issues in FF when pressing return after a style section of text. In Chrome a new block is created but in FF the cursor remains in the styled block and you cannot get out of it unless you already had content below. It makes more sense if you look at the screenshot.

Hi,

Thank you for the style plugin that we use regularly with great success.
We discovered a bug with this week's version of Moodle 3.9. It is no longer possible to configure the style without modifying the text. We use "v3.8-r2" version of the plugin.

Case 1: added the usual style: JSON error

Case 2 : added style with [ and ] > OK

Clément

When I use adapatable theme in moodle 3.3 the Slytes don`t work.
I use atto and the icons are not visible:

I don`t understand, because in other moodle, Styles work good, but with Adaptable no.

The plugin Style does not work with the Adaptable theme (Moodle 3.11).

Thanks

Hi,

I use this plug-in with 2 Moodle and the same settings to custom CSS classes to block and inline text.

• With Moodle 2.9.2, everything works well.
• With Moodle 3.0.2, I discover this bug.
  In "Styles configuration", if I use "inline" with a class in two words with a blank space (example : "h4 myword"), it's impossible to apply the style with Atto.

{ "title": "Title 1", "type": "inline", "classes": "h3 myclass" } = Doesn't work

If I use "inline" with a class in one word (without blank space, example "h4-myword"), I can apply the style with Atto.
{ "title": "Title 1", "type": "inline", "classes": "h3-myclass" } = OK

Best regards.

I was thinking that something like the following might work better as the default / example configuration. As many sites are using a bootstrap-based theme, it will immediately work for them without the need to customize their theme.

{
    "title": "Hero unit box",
    "type": "block",
    "classes": "hero-unit"
},{
    "title": "Well",
    "type": "block",
    "classes": "well"
},{
    "title": "Info text",
    "type": "inline",
    "classes": "label label-info"
},{
    "title": "Warning text",
    "type": "inline",
    "classes": "label label-warning"
}

These are just standard CSS class from
http://getbootstrap.com/2.3.2/components.html that I found useful in
these cases.

Hi,

I translated the English language strings for this plugin into Mexican Spanish in AMOS.

I intended to create a Moodle Docs page in Spanish about this plugin, but I could not get it to work in my local 3.6 server. I am a veterinary pathologist at the largest Mexican University, with no CSS knowledge, like most Moodle teachers.

I think this plugin would greatly improve its usefullness if you could add more detailed documentation, so that a non-programmer reader can actually produce (and use) the five styles illustrated in the screenshot.

Please enclose the text (or a screenshot of it) for the CSS class definitions for Boost.

Please enclose the text for the Styles configuration that will produced the styles shown in the screenshot. I think this text should be used as the actual example in the plugin code.

I think this should not be too difficult nor time consuming for you, but it would greatly help many potential users of this plugin.

Thanks in advance.

Instead of choosing between block and inline, it would be useful to select the specific type of tag we'd like to use, for instance "p", "small", or "blockquote". This would make it use more Bootstrap styling out of the box as well. My main interest, though, is to get people to use HTML elements properly for better screenreader support and the like, without forcing them to know HTML.

I am using Generico atto filter with prettify bundle to insert large blobs of code.
However, for inlines this is not working. Can you please add an example for adding the code style (or tag) within your framework.
Cheers

If there were no functionality changes between 6f8c11f and 9805ef0, why does the plugin now require Moodle 3.1? We are currently running 3.0 and would like to be able to use this plugin and any updates until we upgrade to 3.1.

Folks, thanks for a really useful plugin. I'm attempting to create a multilang span class using this tool, with this:

{ "title": "LANG: EN", "type": "inline", "classes": "\"multilang\" lang=\"en\"" },

Then when I use the editor, highlight some text, and choose the style I get this:
<span class="&quot;multilang&quot; lang=&quot;en&quot;">TEXT IN ENGLISH</span>

This is obviously not what I wanted to achieve since it would appear the additional quotes aren't being escaped. Could someone point me in the right direction as to what I might be doing wrong?

Hello,

When is Moodle 3.9 version going to be released? @Kathrin84

The badge classes are not being applied in Moodle 3.8. The alert and typography styes work properly.

We love this plug in - unfortunately, we have filled it up already. The list is so long that we cannot scroll down to the bottom. Any way to get the list to appear in two columns instead of one?

Moodle has updated their WYSIWYG editor TinyMCE and will be making that the default in the future: https://tracker.moodle.org/browse/MDL-75071.

Would you consider writing a TinyMCE version of the Styles plugin?

Hello.
I am curious if there are plans to include ability to build layout (columns and rows) Thank you.

It seems in Moodle 3.9.7 on Firefox (Chrome and Edge do not have this bug) the document focus isn't set inside the atto editor at the beginning.
When I then select a block style, it is applied outside the editor (e.g. make the page background yellow).

Maybe element = window.getSelection().focusNode; isn't the way to go here? Couldn't you work with the "host" or fetch the "editor"? Or you could doublecheck whether the element is one inside the current editor?

Example in the settings page has bad JSON:

For example:
{
    "title": "Blue box",
    "type": "block",
    "classes": "box blue"
    "preview": true
}

It also would be nice to have some kind of validation, in case the user inputs invalid JSON

Hi, we at ULPGC used this plugin with moodle 3.9 quite happily.
Now we have moodle 4.1, what we see is that the classes defined in config are shown on preview.
But when applied to editor text only the first class in the classes definition is really added. All after the first space is lost
For instance, a definition like
"classes": "badge badge-warning",
only applies
Badge info

whereas
"classes": "badge-warning badge ",
result in text in editor with only
Badge info

The effect is that regular bootstrap classes are missed

The styles button icon image is 21px or so high, higher than the other atto icons.

We had to fix this via CSS, but it would be nice if we didn't have to.