Wrong id used for teacher filter about moodle-block_course_overview_campus

[abias]

Hi Mario,

I added the fields to the get_role_users() function call for 2.8 compatibility. In our installation, the teacher filter works with this code without debug messages and other errors.

Could you please describe why u.id should be added..? Does the filter fail in your installation or do you see performance problems with the current code?

Thanks,
Alex

[mwehr]

Hi Alex,

The teacher filter works without failing. Sometimes the generated list shows multiple entries of the same name.
I become aware of this because one of my collegues asked me why his name was listed multiple times in the teacher filter. What I've seen so far is that the multiple listing of the same name occurs because of ra.id is later used for the user.id at line 452
ra.id changes per context and it looks like that for every course where the user has a teacher role we get a new ra.id -> user.id which results in a new list entry in the teacher filter.

regards,

Mario

[abias]

Hi Mario,

now I see what's the problem. I could reproduce the bug and added the column to the function call as you proposed in commit 1cfbee7.

Thanks for reporting,
Alex

[mwehr]

Perfect!
,... and thx for the credits :-)
Mario