Comments (4)
Hi Mario,
I added the fields to the get_role_users() function call for 2.8 compatibility. In our installation, the teacher filter works with this code without debug messages and other errors.
Could you please describe why u.id should be added..? Does the filter fail in your installation or do you see performance problems with the current code?
Thanks,
Alex
from moodle-block_course_overview_campus.
Hi Alex,
The teacher filter works without failing. Sometimes the generated list shows multiple entries of the same name.
I become aware of this because one of my collegues asked me why his name was listed multiple times in the teacher filter. What I've seen so far is that the multiple listing of the same name occurs because of ra.id is later used for the user.id at line 452
ra.id changes per context and it looks like that for every course where the user has a teacher role we get a new ra.id -> user.id which results in a new list entry in the teacher filter.
regards,
Mario
from moodle-block_course_overview_campus.
Hi Mario,
now I see what's the problem. I could reproduce the bug and added the column to the function call as you proposed in commit 1cfbee7.
Thanks for reporting,
Alex
from moodle-block_course_overview_campus.
Perfect!
,... and thx for the credits :-)
Mario
from moodle-block_course_overview_campus.
Related Issues (20)
- Eye icon not work HOT 1
- Notification : duplicate value - Debug Mode HOT 9
- Missing course category attribute HOT 1
- Suggestion: Students see list of all courses they are enrolled to, but can only access those available. HOT 2
- Bug: Refreshing VLE page shows category as empty HOT 13
- Suggestions HOT 4
- "Undefined variable: modchoices" error whenever I perform an upgrade HOT 2
- Problem with dropdown after logging back in HOT 3
- Error when users are enrolled in too many courses (or long course names) HOT 5
- Plugin Name in language file HOT 7
- pix_url is depraceted in Moodle 3.4 HOT 1
- User can see hidden categories HOT 1
- Moodle 3.5 compability? HOT 1
- Suggestion: Separate link for category/top category at course list output HOT 2
- PHP Notice: Undefined variable / PHP Warning: array_key_exists() expects parameter HOT 3
- Plugin breaks behat tests
- "No courses" text HOT 1
- Please add a "Reset filters" button HOT 3
- Remove course news functionality as it does not work anymore from Moodle 3.7 on HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moodle-block_course_overview_campus.