Plugin Name in language file about moodle-block_course_overview_campus

[2shediac]

Hi - if you look at this revised screenshot - the block title is: [[pluginname]] on the settings screen. So the title in the block is being drawn from this screen, which while correct is confusing. It looks to our customers / etc that its a missing language entry. If you could change the default to not use double brackets and perhaps put the name in, that would help reduce the confusion.

Thanks

[abias]

Hi Derek,

I am fully aware that we are late with updating this plugin, but it is not dead yet.

Apart from this basic lag, could you please elaborate what you mean with "the pluginname on the block title is not translating properly"?

Thanks,
Alex

[2shediac]

Hi Alex - I think your plugin is in great shape - except for this minor issue. I have attached a screen shot. Its Moodle 3.3 - cache has been cleared etc.

Let me know if you need anything else..

[abias]

Hi Derek,

thank you for the screenshot. The added some clarification. However, I am confused how this can happen.

As you see, in https://github.com/moodleuulm/moodle-block_course_overview_campus/blob/master/lang/en/block_course_overview_campus.php#L67, there is a language pack entry for "pluginname".

On https://github.com/moodleuulm/moodle-block_course_overview_campus/blob/master/block_course_overview_campus.php#L52, the title of the block is set defined. It is set to a setting of the block which defaults back to the "pluginname" string as you can see on https://github.com/moodleuulm/moodle-block_course_overview_campus/blob/master/settings.php#L105.

So, if you installed the plugin correctly, the block should have a valid title.

Could you please re-install the block and check if this changes anything? Additionally, please turn on debugging to see if there are any debug messages added to the page when the block is shown.

Thanks,
Alex

[2shediac]

Hi Alex - I think I found the problem. Its the settings when you install the plugin. There is a title that you can setup. See the attached screen shot

Thats where the issue is (I think)

[abias]

Hi Derek,

sorry for the late reply.

Well, your screenshot is about theme_altitude and not about block_course_overview_campus. I simply don't understand what's the problem and what I should fix.

Again, could you please re-install the block and check if this changes anything? Additionally, please turn on debugging to see if there are any debug messages added to the page when the block is shown.

Thanks,
Alex

[abias]

Hi Derek,

thank you for the screenshot. I understand now what the problem is. block_course_overview_campus took the pluginname string from block_course_overview as the default string for the block title. Back in the times when block_course_overview was part of Moodle core, this approach wasn't problematic (although block_course_overview should have been listed as dependency in version.php then).

Now that block_course_overview isn't there anymore from Moodle 3.3 on, this approach breaks.

This bug is now fixed in 1b946ac and will be part of the soon-to-be-released version 3.3 of this plugin.

Thanks,
Alex