moodle-an-hochschulen / moodle-tool_apcu Goto Github PK

The included lib/apcu-gui's license is the PHP License, version 3.01.

According to https://www.gnu.org/licenses/license-list.en.html#PHP-3.01, this license is not compatible with the GNU GPL. As a result, a GPL'ed code (the moodle plugin) cannot be distributed with that library included in one package. As a policy, Moodle HQ does not provide such packages via the plugins directory hosting platform.

Possible solutions to this legal policy blocker is to let administrator themselves to download and deploy the apcu-gui library.

On https://github.com/moodleuulm/moodle-tool_apcu/blob/master/db/upgrade.php#L56-L60, a notification banner is rendered.

Unfortunately, this notification banner has a close button which does not really make sense.
But implementing the notification banner differently, the close button can be removed.
See https://github.com/moodleuulm/moodle-local_profiletheme/blob/master/classes/profilefields.php#L220-L223 for a working example.

Currently, apc.php has to be placed within the plugin directory. To ease the use of this plugin on Moodle installations where plugins must not be modified or where the webserver can't write files into the wwwroot, it should be evaluated if apc.php could be moved to Moodledata instead.

The apc.php file which is fetched from https://raw.githubusercontent.com/krakjoe/apcu/master/apc.php by this plugin is under active maintainance. However, there isn't a strategy to keep this file updated in existing installations currently.

As soon as this is done, UPGRADE.md should be amended.