morikuni / failure Goto Github PK

This is a feature request for wrapping multiple errors.

go 1.20 supports wrapping multiple errors.
https://tip.golang.org/doc/go1.20#errors

But, failure is a lack of support for wrapping multiple errors.

I want support for wrapping multiple errors.

But, I found you are working on v2.
Would you happen to have any plan for support for wrapping multiple errors on v2?

workaround and expected

I wrote current workaround and expected codes below.

err := doSomething(id)
if err != nil {
  // Currently, we have to combine `failure.Wrap and fmt.Errorf`
  return failure.Wrap(fmt.Errorf("foo bar :%w :%w", err, &MyError{
    ID: id
  }))

  // expected like this
  return failure.Wrap(err, failure.Message("foo bar"), failure.WithCause(&MyError{
    ID: id
  }))
}

I don't understand the difference between the following two usages

msg:="not found"
originalErr:=errors.New(msg)

err:=failure.MarkUnexpected(originalErr)
vs
err:=failure.Unexpected(msg)

Can you give me some examples?
What are the different scenarios in which these two functions are used?

Want to output errors in JSON format.

Plan:

1. Add format sub package
2. Add getter interfaces into that package

	type callStacker interface {
		GetCallStack() CallStack
	}
	type contexter interface {
		GetContext() Context
	}
	type messenger interface {
		GetMessage() string
	}
	type coder interface {
		GetCode() Code
	}
	type formatter interface {
		IsFormatter()
	}

3. Support formatting using these interfaces