mostlygeek / arp Goto Github PK

Hello,

This project looks useful as part of something else I'm working on. I wanted to propose a bit of cleanup and just see what your feedback on it is.

You have this PR: #1 which is still outstanding. I think that should be merged.

Also, @jstotz has his fork here: https://github.com/jstotz/arp where he's cleaned a few things up (normalized the address output across platforms, merged the PR above, and some other minor stuff). Those look like sensible changes to me and should probably be merged back here.

There are also two additional points:

• I have a working implementation for MacOS that uses cgo to make the calls directly (see https://gist.github.com/bradleypeabody/21ab61ca639bff2008bde2e28b9f5aef), rather than shelling out to run 'arp' (I tried doing this without cgo just using syscall.Sysctl and that doesn't seem to work). This could replace the existing MacOS implementation.
• I think it would be smart to do just a small abstraction and instead of making the lookup only be IPAddress->MACAddress, it could instead return an instance that implements an interface called something like "AddressInfo" - which could have "MACAddress() string" as a member function, as well as maybe "InterfaceName() string". The underlying implementation could be platform specific so additional fields could also be available through casting if one really so desired. Not vital, but would be nice and easy to do. Would avoid future breaking changes as well.

I can do the work described above. My main question is do you want to continue to house the "main" version here in this repo? (I can't tell if you are maintaining this or not.)

-Brad

I am using this package with the fyne UI toolkit. When the arp command is execured via exec() it pops up a command window that goes away after the arp command is run. To resolve this issue, the following command must be run before doing the exec():
syscall.SysProcAttr{HideWindow: true}

The following snippet should fix the issue:
func Table() ArpTable {
cmd := exec.Command("arp", "-a")
cmd.SysProcAttr = &syscall.SysProcAttr{HideWindow: true}
var outb bytes.Buffer
cmd.Stdout = &outb
err := cmd.Run()
data := outb.String()

Hello, is this repo currently maintained? I am considering using it in an industrial project (respecting the license ofc), but I need to know whether possible PRs would be adressed/merged by the maintainer in a timely fashion.

Given the hypothetical mac address ab:bc:cd:01:02:03, this library returns a table whose values are missing leading zero padding, eg ab:bc:cd:1:2:3. This prevents values in the table from being comparable to the actual mac address.