mountainraptor / bits-key-manager Goto Github PK

Device.pem is used for security certificates. Deleting this key can make the system unusable.

You can upload keys, now download keys

When creating a key using generate or upload the key appears but is a zero file size.

This is caused by create forcing a copy=true in bits/lib/key/key-manager.js

    create({filepath=null}={}) {
      return this.addKeyFromFilepath(filepath, {copy: true});
    }

It could be fixed by updating either the create to allow specification of copy or not, or adding a check to addKeyFromFilepath().

if (copy) {
         // If copy=true and the file is already in the keys directory it causes problems
         let copyClobberFree = path.relative(this._keysDir + '/' + path.basename(filepath), filepath);
 
         if (copy && copyClobberFree) {
            const filename = path.basename(filepath);
            const dst = path.resolve(this._keysDir, filename);
            return Promise.resolve()

In the meantime it could probably be fixed by calling addKeyFromFilepath directly.

Create new public/private key pairs

Probably should not just go around deleting keys without giving the users a chance to back out.

Most errors are in browser console, send to notification center.

*The hover doesn't work for mobile until you tap.
*The download stays as pending on Android (Google Pixel Marshmallow)

Showing the file hash is much more unreliable than using a key fingerprint.

Change icon color to indicate public and private. Also add in title something like (public) or (private).

• Download public key from private key
• Download private key from private key with warning -- maybe password?

Allow derivation of public key from private key.
Allow download of public key from private key.