mozilla-b2g / gonk-misc Goto Github PK

GECKO_OBJDIR will be B2G/objdir-gecko if calling build.sh which refer to .config.
GECKO_OBJDIR will be $(TARGET_OUT_INTERMEDIATES)/objdir-gecko if calling ./build/envsetup.sh & choosecombo & mm gonk-misc.

The second one is used to build gecko only via default Android build environment.
But it made the GECKO_OBJDIR no the same with ./build.sh so we need to build entire gecko again.

Suggestion to modify GECKO_OBJDIR the same with .config.

When it comes time to build B2G for the user or userdebug build flavor, LOCAL_MODULE_TAGS in Android.mk will need to be modified to include these bits in the image.

/dev/socket/rildproxy (and /dev/socket/rildproxyd perhaps) have currently permissions set to 777
it seems that it could be set to 770 after discussing with qDot on IRC, which would restrict it's usage to the radio group and obviously, root

also, the rildproxy can probably be started as user radio instead of start as root and switching to radio (however, that is only a suggestion)

Default mounts should be tighter, especially that we do not need permissions as wide (or as many mounts) as Android requires. (note: those mounts options are not currently required for the recovery mode, defaults are fine)

This reduces the attack surface at the file system level.

The proposed minimum mounts and their options are documented at https://wiki.mozilla.org/B2G/Architecture/Runtime_Security#OS_Hardening

Additional options may be present such as "relatime, barrier=1, data=ordered", etc. but there should be no fewer options.
Additional mounts that are not in use should be removed, such as:

/mnt/sdcard/.android_secure
/sys/kernel/debug
/mnt/secure/asec
/mnt/asec
/mnt/obb

Most mounts are performed in /init*rc. /system has to be mounted rw, then remounted ro (already performed by Android scripts). It is acceptable to have all the mounts "fixed up" in /init.rc or /init.b2g.rc as well.

ionmonkey currently regresses on ARM, so we'll be disabling it for v1. This is the configuration that the buildbots will (are) using.

CC @jhford

This means the Nuwa work in bug 771765 would add a process that would cause b2g-info to emit ugly errors on stderr and there would be a mysterious process in the output.

It's a tiny script, and |ps| is already in all builds, so we should take b2g-ps.

Building B2G on my machine consistently hung my medium-powered laptop, and eventually I traced it to this setting.

It's possible that this only came to light because GECKO_MAKE_FLAGS is normally set and that there's a configuration problem elsewhere in my B2G tree. Still, this is a very strange default and when it leads to a problem as it did for me, it is rather hard to diagnose.

In my (relatively uninformed) opinion, this line of code is best removed.

Here's my use case: I need to some framebuffer device hackery, because life sucks sometimes. The only sane place I could think to include that was b2g.sh. However, no way that's something we want to take upstream, it's very specific to Raspberry Pi.

I landed a hack to just import b2g.sh into my device/.../ dir, but that sucks. But deadline approacheth.

My thought was to add a vendor hook to b2g.sh to support that use case. Something along the lines of

test -x /system/bin/b2g_vendor_init.sh && /system/bin/b2g_vendor_init.sh

near the beginning of /system/bin/b2g.sh. Can anyone think of better ways?

I can make this change (eventually), but if it's just going to get r-, no point wasting anyone's time.

Github gonk-misc pull request 39 contains a shell syntax error that causes ENABLE_MARIONETTE never being defined. An error message is shown during build time:

gecko/build/autoconf/mozconfig2client-mk: 2: [: eng: unexpected operator

Then when we starts marionette test, it will get blocked and waits until timeout.

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)