mozilla-mobile / focus-android Goto Github PK

This would go in Settings as well.

Design specs to follow but I'm mostly looking to inherit our work from Android with some visual clean up.

Building and signing releases should be automated. And we do not want to fiddle around with the signing certificate on our dev machines.

Theme: Default Browser

User Story

I discovered content of a page that I want to revisit later (save to my device)

Feature

Support for downloads (file downloads, PDF, execs)

Background

Currently just nothing happens when clicking a link that should start a download.

This should be fairly easy to implement using WebView (I guess), but could be more complicated with Gecko. Downloads are not part of the GeckoView MVP. However we might be able to work around that with some custom JavaScript.

Maybe we just want to intercept the download and let Android's download manager perform the task (privacy concerns?).

Tasks

• Implement DownloadListener
• UX mocks / flow
• Show dialog to let the user confirm the download (see UI mock)
• Show snackbar once download is finished
• Request runtime permission to write to external storage
• Forward Download to Android's Download Manager
• Add telemetry probe

UI mock

When opening a market:// URL linking to the Play store the app crashes:

System.err  W  java.lang.IllegalArgumentException: Malformed URI supplied
            W      at org.mozilla.focus.webkit.matcher.EntityList.isWhiteListed(EntityList.java:38)
            W      at org.mozilla.focus.webkit.matcher.UrlMatcher.matches(UrlMatcher.java:85)
            W      at org.mozilla.focus.webkit.TrackingProtectionWebViewClient.shouldInterceptRequest(TrackingProtectionWebViewClient.java:30)
            W      at android.webkit.WebViewClient.shouldInterceptRequest(WebViewClient.java:185)
            W      at com.android.webview.chromium.WebViewContentsClientAdapter.shouldInterceptRequest(WebViewContentsClientAdapter.java:321)
            W      at org.chromium.android_webview.AwContents$BackgroundThreadClientImpl.shouldInterceptRequest(AwContents.java:527)
            W      at org.chromium.android_webview.AwContentsBackgroundThreadClient.shouldInterceptRequestFromNative(AwContentsBackgroundThreadClient.java:38)

STR:

• Go to mozilla.org
• Scroll down to the Firefox teaser
• Click on the "Get it on Google Play" button

Currently, we went with a + icon from the Android lib., we should update that

Also we should match functionality here with

• Forward,
• refresh/stop
• share

Design specs to come.

Mostly looking for a simple scroll/fade here - just like on iOS !

Core Ping:

• add core ping
• add missing core ping fields

Events:

• event: bring_to_foreground
• event: send_to_background
• event: (share)
• event: (open...various types)
• event: browse (enter)
• event: browse (intent)
• event: search (type)
• event: search (select)
• event: erase (button)
• event: erase (back)
• event: settings change

Misc:

• Send to production endpoint
• Enforce limits (-> #428)

Once we get the icon in, we should leave a shortcut to the Settings above the keyboard when the user is typing. Again, mostly for iOS parity.

UX should work together with Eng here to figure out how to keep this simple and moving forward. We will likely be able to fork over a lot of the UX but there will still need to be some massaging I think.

To match Focus on iOS, as the user is typing, let's add UI to give them the ability to commit a search instead of auto-completing the top alexa URL.

I'm calling the "typing" screen the awesomescreen here (just to be clear).

• #1047
• #652
• #625
• #609
• #1527
• #1620

The first prototype iteration is using a WebView. The reason for that is mostly that GeckoView is not ready to be used in the way we want to.

The platform team has identified the tasks for shipping a GeckoView MVP that meets the requirements for Focus for Android. This work is tracked on Bugzilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=1322573

We used a placeholder from the Android Lib (I think?) in Kona, we should update that to match ours to help with cross-product consistency here.

We need to somehow get the app translated by our translators. Figure out how.

Explore our options for collecting telemetry. What system does Focus for iOS use?

Currently we show the lock icon whenever we are displaying a https URL. That's not ideal. The code should look at the certificate to determine whether this is a secure connection. Basically the same we do for displaying a "green lock" in Fennec.

It probably makes sense to wait until we switch to GeckoView before implementing this.

We want to be able to switch to GeckoView in the future (#13). Until then it would be handy to have a secondary gradle configuration for building Focus with GeckoView. To make this simple and less painful we should hide all WebView related things behind a shared interface.

Our current icon is the iOS icon dropped into Android's asset studio. The result looks quite bad. We need an actual icon.

We either need to handle the rotation ourselves (that's what Fennec does) or restore the previous state correctly. Currently it is at least broken when opening a URL from an Intent and the device is rotated.

Matching what we have on iOS would make the most sense here. Not sure if we 100% need the same animation with the wave graphic but I just wanted to file this first in case I forgot.

Currently we have two activities:

• MainActivity
• BrowserActivity

To make navigation and intent handling easier it would be helpful to transform them into a single activity. In addition to that sometimes the content of the "main activity" is visible from the browser activity (Compare with iOS). That's also much easier if it's just one activity.

A first version has been implemented in 74abf42. Currently we only refill the URL bar with the URL from the Intent and do not load the website directly. This prevents us from accidentally loading an URL that the user actually did not want to load. However this is not user friendly when opening multiple URLs a day.

When in typing mode, the user can dismiss and exit this mode by tapping above the keyboard.

Currently we build the app for Android 7.0+. Let's investigate how far we can go down with adding overhead by implementing system features ourselves. This will primarily be driven by the feature set we require from WebView.

Currently we just have a share action but no way to switch to an actual browser.