Cookie Banner handling Focus about focus-android

[iorgamgabriel]

Ok ,thank you @Amejia481

[iorgamgabriel]

@jeffreygee Thank you for the design !
This is the GeckoView interface for Cookie banner

 * Represents settings options for cookie banner handling.
enum class CookieBannerHandlingMode(val mode: Int) {
  
     * The feature is turned off and cookie banners are not handled
    DISABLED(0),

     * Reject cookies if possible
    REJECT_ALL(1),

     * Reject cookies if possible. If rejecting is not possible, accept cookies
    REJECT_OR_ACCEPT_ALL(2),
}

Synthesising the Figma design we will have the following 3 scenarios:

1)If the 'Auto cookie banner consent' is not checked 'Further reduce cooke banners' item will be invisible and value for Cookie banner conform GeckoView interface will be DISABLED(0).
2) If the 'Auto cookie banner consent' is checked 'Further reduce cooke banners' item will be visible and unchecked the value for Cookie banner conform GeckoView interface will be REJECT_ALL(1).
3)If the 'Auto cookie banner consent' is checked 'Further reduce cooke banners' item will be visible and checked the value for Cookie banner conform GeckoView interface will be REJECT_OR_ACCEPT_ALL(2).

PS : If the user unchecked 'Auto cookie banner consent' 'Further reduce cooke banners' will become unchecked .
When the user enters first in the App the value will be DISABLED(0) first case.

Screen_Recording_20221107-162523_Firefox.Focus.mp4

@rtestard @jeffreygee @amedyne Is it correct?

[Amejia481]

@lobontiumira thanks 🎉 !

[iorgamgabriel]

This is what I should implement in Focus ? An entry in Focus Settings(first image) under Block cookies with the name "Auto cookie banner consent" like in Fenix (last image) that will redirect the user to this screen(second image) ?

@amedyne @rtestard @jeffreygee

[Amejia481]

👋🏽 the Fenix UI still hasn't finalized I'm not sure about Focus, you can find the mockups here https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020 @jeffreygee can help to clarify.

[iorgamgabriel]

https://www.figma.com/file/o3TMGgSnpGNvA9GXb7FUu6/Auto-Cookie-Banners-(Focus)?node-id=603%3A17020
On the second screen, the new cookie banner cfr will appear instead of the track protection cfr ?

[jeffreygee]

Sorry, I didn't realize these were being built out already. But yes, it will follow this UI on this Figma. I will update this tomorrow with the Light/Dark modes

We're currently doing testing on the content, but that will just be copy changes if anything.

@iorgamgabriel - to answer your question, discussed this with @rtestard and I believe the decision is that cookie banner CFR wouldn't be triggered until onboarding was complete. I'll let Romain confirm here.

[iorgamgabriel]

I think we shouldn't put an arrow next to the "Auto cookie banner consent" entry, because the arrow is used only for "Block cookies," which will trigger a pop-up.

In your Figma "Site Permissions" entry has an arrow, but in the app it doesn't. @rtestard @jeffreygee

[rtestard]

Yes, the trigger should be per spec:
After completion of new users onboarding, on the first instance of a cookie banner that gets cleared, a panel opens off of the shield button...

[iorgamgabriel]

@rtestard But if the site has trackers the cfr for tracking protection will appear in the same place and in the same time like this one .

[rtestard]

@iorgamgabriel Agreed that "Site permissions" should the same pattern as "Auto cookie banner consent"
"Studies" has the same pattern and also no arrow.
@jeffreygee should they all have an arrow or none?

[iorgamgabriel]

What state should the cookie banner be in when the user has enabled it? REJECT_ALL(1) or REJECT_OR_ACCEPT_ALL(2)

The icon on the panel should be different if the cookie banner is enabled or disabled?
@rtestard @jeffreygee @amedyne

[rtestard]

This UI should only appear if the feature is enabled inside preferences and the user is on a site from the list.(see 2.8.2 on https://docs.google.com/document/d/1TQxbvXT_1Pkd4ZvuFGH7nq3JSodiBS4DEFZcfulotvk/edit)
If the feature is enabled inside preferences and the user is on a site from the list and the per site toggle is enabled then the preference will drive the state the cookie banner should be in.
@jeffreygee I think we need a different icon when Auto cookie banner consent is disabled, in a similar way to how the shield gets crossed, agreed?

[jeffreygee]

@rtestard - agreed. I've just put in a request for this with the design systems team

[jeffreygee]

Making a note here that we've received the new cookie icon for disabled and no detected. Updated in the figma file.

[lobontiumira]

Verified on a local debug build that:

• the "Cookie Banner Reduction" option is available in Settings - Privacy & Security - Cookies and Site Data,
• the "Further reduce cookie banners" option is displayed only when the "Cookie Banner Reduction" toggle is enabled,
• the "Further reduce cookie banners" option can be checked/unchecked, and it is working correctly.

Note:

• enabling the "Cookie Banner Reduction" toggle, and the "Further reduce cookie banners" option, does not dismiss the cookie banners of ALL the websites from the Cookie Banner list - I'll file new issues on Bugzilla, as soon as I identify all the problematic websites.
  I'll remove the QAReady label for now, and close this ticket.