mozilla / basket

INACTIVE - Moved to the Mozilla Marketing Org

Basket

This project has moved to our new Mozilla Marketing GitHub Organization. Please follow us there.

Thanks,

Mozilla Marketing Webdev Team

basket's Issues

Add documentation

Basket needs doc on how the API works and what the behavior is.

README says Python 2.6, tests use Python 2.7

README.rst says the requirement is Python 2.6

apps.news.tests.UpdateUserTests uses assertDictEqual which wasn't added until Python 2.7.

There are several ways this could be addressed:

• Update requirement to Python 2.7
• Upgrade to at least Django 1.3, which provides a backport of the Python 2.7 unittest features
• Install and use the unittest2 package, which again provides a backport of the Python 2.7 unittest features
• Rewrite the tests

Refactor huge tests file

news/tests.py is almost 1000 lines long, it's time to refactor it into separate test files (news/tests/test_aaa,py, news/tests/test_xyz.py, etc)

Tests don't run with `manage.py test`

Really, no tests? This makes Sad Panda even sadder!

These tests should include a test that the user endpoint accepts both GET and POST request as that was the issue that made me find this out in the first place.

Validate email addresses and convert domains for IDNA

Look into using flanker again.

When a SOAP connection doesn't respond, service simply quits with no log

When the HTTP connection used by SOAP doesn't respond, the service quits and doesn't log anything. We need to catch this exception and make sure it gets logged correctly.

Specific traceback:

File "/Users/james/projects/mozilla/basket/venv/lib/python2.6/site-packages/suds/transport/http.
py", line 118, in u2open
return url.open(u2request, timeout=tm)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 3
83, in open
response = self._open(req, data)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 4
01, in _open
'_open', req)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 3
61, in _call_chain
result = func(*args)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 1
138, in https_open
return self.do_open(httplib.HTTPSConnection, req)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 1
105, in do_open
raise URLError(err)
urllib2.URLError: