mozilla / basket-client

Python library for connecting to Basket

Basket Client

This is a client for Mozilla's email subscription service, basket. Basket is not a real subscription service, but it talks to a real one and we don't really care who/what it is.

Docs

Documentation can be found at http://basket-client.rtfd.org/

License

This software is licensed under the BSD License. For more information, read the file LICENSE.

basket-client's Issues

Requests is required on setup

setup.py imports basket to get at the metadata contained there in, such as author. That init.py also imports base.py. The base.py then requires requests to be imported. Now that's normally fine if you've done an install with dependencies.

Unfortunately on marketplace (and other mozilla sites using pip), we do that with --no-deps, so that we don't get surprised when libraries install things for us at some version.

Sadly that means when we pip install basket client, requests is not installed yet, so we get:

[localhost] out: Using download cache from /tmp/pip-cache/http%3A%2F%2Fpyrepo1.addons.phx1.mozilla.com%2Fbasket-client-0.3.0.tar.gz
[localhost] out: Running setup.py egg_info for package basket-client
[localhost] out: Traceback (most recent call last):
[localhost] out: File "", line 16, in
[localhost] out: File "/data/addons-dev/src/addons-dev.allizom.org/venv/build/basket-client/setup.py", line 3, in
[localhost] out: import basket as distmeta
[localhost] out: File "basket/init.py", line 3, in
[localhost] out: from base import (send_sms, subscribe, unsubscribe, user,
[localhost] out: File "basket/base.py", line 9, in
[localhost] out: import requests
[localhost] out: ImportError: No module named requests
[localhost] out: Complete output from command python setup.py egg_info:
[localhost] out: Traceback (most recent call last):
[localhost] out:
[localhost] out: File "", line 16, in
[localhost] out:
[localhost] out: File "/data/addons-dev/src/addons-dev.allizom.org/venv/build/basket-client/setup.py", line 3, in
[localhost] out:
[localhost] out: import basket as distmeta
[localhost] out:
[localhost] out: File "basket/init.py", line 3, in
[localhost] out:
[localhost] out: from base import (send_sms, subscribe, unsubscribe, user,
[localhost] out:
[localhost] out: File "basket/base.py", line 9, in
[localhost] out:
[localhost] out: import requests
[localhost] out:
[localhost] out: ImportError: No module named requests
[localhost] out:
[localhost] out: ----------------------------------------
[localhost] out: Command python setup.py egg_info failed with error code 1 in /data/addons-dev/src/addons-dev.allizom.org/venv/build/basket-client
[localhost] out: Storing complete log in /root/.pip/pip.log

There's no real reasons requests is needed during the setup, its just an import side effect. If that could be removed that would be swell.

Improve Testing and Deployment

Thanks to #31 being filed I've realized that this project could use some love. So I'd like to do the following:

• Move to Travis CI so that we get automated python package builds and deployments to PyPI
• Add tox and tox-travis so that we run against many more Python versions
• Make sure we're Python 3 compatible

See django-allow-cidr for Travis and Tox configs done in a way that we'd like them to be.

Migrate to CircleCI v2 config

Not sure if this repo is still "active", or if we should archive it, but...

---

I recently got an email from "The CircleCI Team" saying:

Last month, we pointed you toward resources to help you migrate active projects from CircleCI 1.0 to 2.0 with the Migration Center.

With only 30 days left until CircleCI 1.0 sunsets, we want to ensure you have everything you need to help you with any active projects that still need to migrate to 2.0. Our team has been busy creating resources and new features to help make it easier:

More info in the CircleCI Blog at https://circleci.com/blog/sunsetting-1-0/ and https://circleci.com/docs/2.0/migration-intro/

I also found https://circleci.com/docs/2.0/local-cli/ which points to a handy CircleCI v2 config validator (using something like $ circleci config validate -c .circleci/config.yml).

Tests!

We should probably have some.

Push Git tags

Seems as if the last person that has done PyPI releases didn't push Git tags up