GithubHelp home page GithubHelp logo

Comments (4)

marco-c avatar marco-c commented on June 19, 2024

Looks interesting, I'll take a stab at it.

from oghliner.

mykmelez avatar mykmelez commented on June 19, 2024

Marco, these tests broke the next time I merged a change to master (https://travis-ci.org/mozilla/oghliner/builds/85199186), because the tmp dir was apparently preserved across builds:

  1. Deploy should update the gh-pages branch in the origin repo and publish files to it:
    Error: EEXIST, file already exists 'tmp'
    at Error (native)
    at Object.fs.mkdirSync (fs.js:747:18)
    at Context. (test/testDeploy.js:49:8)

from oghliner.

brendandahl avatar brendandahl commented on June 19, 2024

The temp folder/file creation library I used in https://github.com/mozilla/oghliner/pull/63/files#diff-c792d04edfea01487109cfd6450c9ef8R4 worked pretty well.

from oghliner.

marco-c avatar marco-c commented on June 19, 2024

@mykmelez I think it was a timeout, which then caused the "tmp" directory to be preserved and thus the second test to fail.
It's likely that the test could actually need more time, as in this successful build (https://travis-ci.org/mozilla/oghliner/builds/85199186, which is yours retriggered) the test took 673ms (which is relatively close to the current timeout of 2 seconds).

Let's file a new issue if it happens again.
I'll also submit a PR to avoid failing following tests when the first runs out of time.

from oghliner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.