Comments (4)
Looks interesting, I'll take a stab at it.
from oghliner.
Marco, these tests broke the next time I merged a change to master (https://travis-ci.org/mozilla/oghliner/builds/85199186), because the tmp dir was apparently preserved across builds:
- Deploy should update the gh-pages branch in the origin repo and publish files to it:
Error: EEXIST, file already exists 'tmp'
at Error (native)
at Object.fs.mkdirSync (fs.js:747:18)
at Context. (test/testDeploy.js:49:8)
from oghliner.
The temp folder/file creation library I used in https://github.com/mozilla/oghliner/pull/63/files#diff-c792d04edfea01487109cfd6450c9ef8R4 worked pretty well.
from oghliner.
@mykmelez I think it was a timeout, which then caused the "tmp" directory to be preserved and thus the second test to fail.
It's likely that the test could actually need more time, as in this successful build (https://travis-ci.org/mozilla/oghliner/builds/85199186, which is yours retriggered) the test took 673ms (which is relatively close to the current timeout of 2 seconds).
Let's file a new issue if it happens again.
I'll also submit a PR to avoid failing following tests when the first runs out of time.
from oghliner.
Related Issues (20)
- Update travis-encrypt to version 2
- Oghliner service worker is not deleting out of date offline caches HOT 1
- Tests intermittently fail
- For each `index.html`, cache its parent directory too HOT 1
- Use arrow functions in the service worker HOT 1
- Make Service Worker tests to run on Travis HOT 2
- Provide integration tests for the service worker
- Rewrite some of the testOffline.js tests HOT 3
- Provide a site-root option to allow the offline manager to be included at any page HOT 2
- Setup code coverage for service worker tests
- Assert that prepareCache returns a cache HOT 1
- Consider taking into account imported scripts via `importScript` to generate cache name HOT 1
- Make the update event smarter by avoiding re-fetching non changed files
- Display update notifications for global CLI using update-notifier
- templatze or customize the "a newer version of this page is availalbe" message in offline-manager.js
- oghliner offline ./dist/ doesn't strip dist/ from paths of offlined files
- oghliner.deploy is a footgun HOT 3
- "CLI interface, oghliner as a template/tool" live tests failing HOT 1
- test-sw fails with 'Cannot load browser "Chrome"!'
- switch to using the "deploy" step with a "script" provider
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oghliner.