Comments (4)
Was this based on the old flow of cloning the repo?
It seems we should just take the npm version of oghliner and put that into the index.html file during oghliner bootstrap
.
from oghliner.
Was this based on the old flow of cloning the repo?
This is actually to determine the deployed version of an app based on the template, not to determine the version of the template that was used to create the app.
@wfwalker asked for this when he was debugging an app update whose differences from the previous version of the app were subtle. He wanted to ensure that the app his browser was loading was the new version rather than the old one.
Since the "version" in this case is just the particular Git revision that he deployed, writing the revision ID into the index.html file before deploying it would enable him to figure out what version of the app he's looking at by checking that value in the HTML file.
(Including the version of Oghliner that was used to bootstrap the app would also be useful, as would a reference and link to Oghliner.)
from oghliner.
@mykmelez Do we still want to do this after @wfwalker's comment of "I think I mostly want to have programmatic knowledge of whether this instance of the app is up to date"?
I think the current issue description could still be a nice feature, but it does make us bring in templating to the template app build step.
from oghliner.
I think the current issue description could still be a nice feature, but it does make us bring in templating to the template app build step.
Hmm, indeed. I agree, it'd be a nice feature to have (even if it isn't the feature that @wfwalker actually wants!). And I'm ok with adding templating to the template app build step (even though it reminds me of Inception!). But it doesn't need to happen for v1.
from oghliner.
Related Issues (20)
- Update travis-encrypt to version 2
- Oghliner service worker is not deleting out of date offline caches HOT 1
- Tests intermittently fail
- For each `index.html`, cache its parent directory too HOT 1
- Use arrow functions in the service worker HOT 1
- Make Service Worker tests to run on Travis HOT 2
- Provide integration tests for the service worker
- Rewrite some of the testOffline.js tests HOT 3
- Provide a site-root option to allow the offline manager to be included at any page HOT 2
- Setup code coverage for service worker tests
- Assert that prepareCache returns a cache HOT 1
- Consider taking into account imported scripts via `importScript` to generate cache name HOT 1
- Make the update event smarter by avoiding re-fetching non changed files
- Display update notifications for global CLI using update-notifier
- templatze or customize the "a newer version of this page is availalbe" message in offline-manager.js
- oghliner offline ./dist/ doesn't strip dist/ from paths of offlined files
- oghliner.deploy is a footgun HOT 3
- "CLI interface, oghliner as a template/tool" live tests failing HOT 1
- test-sw fails with 'Cannot load browser "Chrome"!'
- switch to using the "deploy" step with a "script" provider
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oghliner.