GithubHelp home page GithubHelp logo

Comments (4)

brendandahl avatar brendandahl commented on June 16, 2024

Was this based on the old flow of cloning the repo?

It seems we should just take the npm version of oghliner and put that into the index.html file during oghliner bootstrap.

from oghliner.

mykmelez avatar mykmelez commented on June 16, 2024

Was this based on the old flow of cloning the repo?

This is actually to determine the deployed version of an app based on the template, not to determine the version of the template that was used to create the app.

@wfwalker asked for this when he was debugging an app update whose differences from the previous version of the app were subtle. He wanted to ensure that the app his browser was loading was the new version rather than the old one.

Since the "version" in this case is just the particular Git revision that he deployed, writing the revision ID into the index.html file before deploying it would enable him to figure out what version of the app he's looking at by checking that value in the HTML file.

(Including the version of Oghliner that was used to bootstrap the app would also be useful, as would a reference and link to Oghliner.)

from oghliner.

brendandahl avatar brendandahl commented on June 16, 2024

@mykmelez Do we still want to do this after @wfwalker's comment of "I think I mostly want to have programmatic knowledge of whether this instance of the app is up to date"?

I think the current issue description could still be a nice feature, but it does make us bring in templating to the template app build step.

from oghliner.

mykmelez avatar mykmelez commented on June 16, 2024

I think the current issue description could still be a nice feature, but it does make us bring in templating to the template app build step.

Hmm, indeed. I agree, it'd be a nice feature to have (even if it isn't the feature that @wfwalker actually wants!). And I'm ok with adding templating to the template app build step (even though it reminds me of Inception!). But it doesn't need to happen for v1.

from oghliner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.