mozilla / popcorn.webmaker.org

RETIRED

Popcorn Maker

RETIRED

Read more on our blog

Should you desire to run popcorn maker locally, the last tagged version is v2.1.41

popcorn.webmaker.org's Issues

Order of text events drop down (top/bottom/left/center...)

If you add a text events and change the placement of the text, the order of the items in the drop down are not logical.

center
bottom
top

center
left
right

In my language it would be more logical with:

top
center
bottom

left
center
right

I guess in languages that use right to left writing it might be different.

Welcome message is not pointing to the right place

This welcome message is not pointing to the correct place.

Clear Events also deletes layers

Maybe "Clear Events" in the menu should be called called something else, because it also deleted the layers.

Re-purpose this repo for popcorn-editor

popcorn-editor is the future of Popcorn Maker. As such, we shall take the current contents of https://github.com/mozilla/popcorn-editor/tree/master and make that the current master branch here.

TODO:

• Create a popcorn-editor branch, tracking https://github.com/mozilla/popcorn-editor/tree/master
• Clean out Issues in this repo
• Modify the README in popcorn editor to explain the change from popcorn.webmaker.org - or link to a blog post doing just that. Also link to the last stable release tag of popcorn maker - v2.1.41
• replace master branch with popcorn-editor branch
• Delete mozilla/popcorn-editor - Migrate issues here?
• Rename this repo popcorn-editor
• rejoice

Double scrollbars

Go to https://keyboardkat.makes.org/thimble/LTc4ODY2MDIyNA==/maker-party-event-reporter and notice how there might be two scrollbars.

Click "Details" to bring down the details and here there is also double scrollbars.

We can add one of these CSS codes to the iframes, depending on if we want the iframes to be block og inline to get rid of the double scrollbars:

vertical-align: bottom;
display: block;

Missing option of deleting event without using keyboard

It would be nice to be able to delete an event with the cursor/mouse and not having to press delete on the keyboard.

Maybe there could be a trashcan icon in the top and users would be able to drag the event to the trashcan to delete it.
And an option in the events setting, like a X os something.
There is a X but that just goes back to the events.

Add favicon

Popcorn Maker and Appmaker have they own favicon, but X-Ray Goggles and Thimble just use the Mozilla one, same as Webmaker main website.

So maybe add a favicon ?

No 'Access-Control-Allow-Origin' header is present on the requested resource.

Attempting to preview a project will trigger multiple errors in the console: No 'Access-Control-Allow-Origin' header is present on the requested resource. The page is viewed from localhost:12319 and attempts to load resources from localhost:8888

The issue can temporarily be fixed by adding the following to server.js:

app.use( function ( req, res, next ) {
    res.header( "Access-Control-Allow-Origin", "*" );
    next();
  });

This is obviously bad practice and a major security issue.

Scroll bar in events dont allways allows me to scroll all the way down

On the 3D model event for example there is a video at the bottom, but the scroll bar dont allow me to scroll down to the bottom, i can just see the top of the video, but i can scroll down with the mouse.

YouTube links not working on demo site.

Tried pasting a link in the demo

ie: https://www.youtube.com/watch?v=9bZkp7q19f0

It says 'This YouTube video is unplayable'.

Was there a change to the YouTube API perhaps?

Vimeo seemed to be working fine.

ie: https://vimeo.com/65843745

"Popcorn Maker encountered an error" when leaving Popcorn page

When i leave Popcorn to go to another website i get a message just as i leave.
It says "Popcorn Maker encountered an error" and then some text and a textarea and two buttons.

This is only showned for about 2 seconds so it it ratcher useless because i have no time to read it or react on it, so i would prefer not showing messages like that when i dont have the time to read it anyway because the browser is loading another website.

Proper way to update TrackEvents ?

Following Popcorn question:
mozilla/popcorn-js#443

How do you reset/remove popcorn registered events when you change start or duration in WebMaker ? I did something like:

popcorn.myplugin({ start: 1, end: 2, duration: 1, custiom: 'x' });

But what is the proposer way to remove / update it after ?

Redirect to Webmaker

Redirect authoring environment to Webmaker.

Popcorn Makes Dissapeared

Webmaker User: saramariacher
Lost: Two Popcorn Makes

Saved the makes at the beginning of February.
Noticed they were lost one week later.

Any ideas?
@cadecairos @jbuck

Suggest change for "This page doesn't exist"

I dont think "This page doesn't exist" sounds right.
I sounds like im watching something that doesn't exists.

"Page not found" or "The page you where trying to view does not exists" might be better.

But i havent tried the string in the product so maybe someone else could see what sounds best.

But seem webmaker.org have another error page so maybe use the same error page.
https://webmaker.org/iauwefnliauwnefiawuenf

Duration of Youtube videos is wrong

As explained in [https://github.com/mozilla/popcorn-js/issues/440](this issue on pocketsphinx-js repository), Youtube API v2 is deprecated, and duration retrieved with a call to that API (in public/src/util/mediatypes.js) is wrong, it always returns 236 seconds.

I proposed a valid way to retrieve the duration and [https://github.com/mozilla/popcorn-js/pull/441](opened a pull request in pocketsphinx-js). I can make one for that repository if that helps.

YouTube in makes don't work

Some video content in Popcorn makes has stopped working properly (e.g. https://nazareth.makes.org/popcorn/2pue).

@ScottDowne thinks this is due to an API change.

@simonwex can you advise here? What kind of priority should we put behind maintenance like this?

Suggestions for changing string

"Results" seem to be used after another word like "YouTube Results" så i guess it should be "results" with small startingletter, but i dont know if it used other placer.

Double events title

If i click "+ Events" to add an events, underneath appear "Events".
And if i select text event it says "Events > Text".

But it already says Events on the tab.
So why would it have to say Events just under the tab ?

Maybe some kind of plan for the future, but as it is right now i dont see the reason why "events" should appear two times.

First layer is called "Layer 0"

Would it not be better to call the first layer for "Layer 1" instead of "Layer 0" ?

Add links to popcorn-editor on README and deprecation page

as ben suggested, we should link to the successor of Popcorn Maker, Popcorn Editor!

cc/ @benrito @KevZawacki

Error: Postgresql not supported

Hi all.

Have popcorn.webmaker running on Heroku mostly successfully (I can't save makes, check my other issues to see what's up). It is pointing at my heroku postgres DB, as the documentation says is supported.

However, I am getting this error in my logs:
2015-07-08T04:09:53.768695+00:00 app[web.1]: lib/project.js: DB setup error 2015-07-08T04:09:53.768701+00:00 app[web.1]: undefined The dialect postgresql is not supported.

Why would this happen?

As far as I can tell, this might also be responsible for my inability to save makes?

Uncertain copy: "Paste an HTML5 link"

Hi there, I'm not sure of what is meant by an "HTML5 link" in the placeholder text field copy "Paste an HTML5, YouTube, Vimeo, or SoundCloud link here" for adding media to a project. Does this mean a video file source from a video tag? Or the whole tag itself? It seems like there could be a more clear wording.

Wikipedia event default language

I think the default language of the Wikepedia event should be the same language as Popcorn are being using in.

"No Flash" message appears erroneously

According to bmoskowitz, in recent Firefox, the No Flash message appears even though he has Flash installed. Perhaps Popcorn is checking at the wrong time? He said Firefox recently made some changes to late-load plugins, or something...

Text events does not fallback

If you block fonts.googleapis.com the text events does not show any text.
There are no fallback font and the text is removed, so even if there was a fallback font (like the pop events) there is no text to show.

"Minutes" is not translateable

If i get a pop-up message about an automatic backup it might say something like "5 minutes ago".
It seem that "minutes" are not translateable on Transifex.

Hover curson over speaker icon shows selection cursor

I would expect the standard pointer or the hand to show that its clickable.

"Background (Transparency)" works opposit

"Background (Transparency)" for 3D model event seems to do the opposit.
When i select the check box i dont have transparent background.
When i deselect the check box i do.

Wikipedia Language drop-down is not alphabetically sorted

When adding a Wikipedia event and selecting language drop down the languages does not appear in a-z order.

Popcorn running fully on Heroku [saving make issue]

Hi there!

Tagging @Pomax, for helping me earlier today.

I am attempting to get a popcorn instance fully functional on my own Heroku instance.

So far, I successfully have popcorn, login, and makeAPI instances running.

I am able to login via popcorn using either Persona or email login. However, I am unable to save makes. I get a generic "something went wrong" error, and my best guess is that Popcorn is not communicating with MakeAPI. However, I am not quite sure how to point Popcorn to Make. In the Popcorn config file, I have the MAKE_ENDPOINT set, however all of my makes are attempting:
POST /en-US/api/project/ 500 19ms - 66b

I am not quite sure where this route is coming from, or where it should be pointed at, and the documentation is difficult to get a complete picture from.

Is it relevant to the configuration's AUDIENCE parameter? I am unsure as to what this does as well.

Any guidance/further information needed?

npm ERR! Error: version not found: [email protected]

media@mediaprocessor:~/popcorn/popcorn.webmaker.org$ sudo npm install npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No repository field.
npm ERR! Error: version not found: [email protected]
npm ERR! at /usr/local/lib/node_modules/npm/lib/cache/add-named.js:125:12
npm ERR! at saved (/usr/local/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:167:7)
npm ERR! at Object.oncomplete (fs.js:107:15)
npm ERR! If you need help, you may report this entire log,
npm ERR! including the npm and node versions, at:
npm ERR! http://github.com/npm/npm/issues

npm ERR! System Linux 3.5.0-49-generic
npm ERR! command "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! cwd /home/media/popcorn/popcorn.webmaker.org
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.4.28
npm ERR! not ok code 0

According the author, [email protected] was unpublished because they shipped with a default validation server that doesn't exist anymore, and it won't let me install with version 0.2.3

Any suggestions are appreciated.

jQuery dependency resolution causes published makes to not load

Popcorn's package.json lists jQuery v1.8.3 as a dependency, but Makerstrap causes bower to resolve jQuery to version 2.1.3.

This is a problem because published makes try to load /static/bower/jquery/jquery.min.js which doesn't exist in 2.1.3, since it's been moved to /static/bower/jquery/dist/jquery.min.js

Exported webmaker video on iOS/Android

Hi,

I didn't manage to replay webmaker's videos on iOS or Android devices (I used that one I did myself https://stuffk.makes.org/popcorn/25ef, it's just one imported youtube video)
Did I miss something or "mobile" support is not ready and planned for later ?

Odd behavior when change layer name with space followed by a number at the end

Try changing the "Layer 0" layer to "Layer 1" or "Layer 99" or something.
It keeps the name "Layer 0".

If using two spaces before the number it works.
"Layer 55a" works to when it ends with something that is not a number.

So seems like when it ends with a space and a number it wont change the name.

Installing on Heroku

Hi there.

Having issues getting popcorn working properly on Heroku.

It detects the node buildpack, and proceeds to install, but hits an error while installing node-gyp rebuild, which apparently is being executed by node-expat which is something that never actually appears in /node_modules so I am having difficulty tracking it down. The error is too far back in my error logs to retrieve, but was basically a version compatibility error as described roughly here: hipchat/hubot-hipchat#232

I have, however, been able to surpass this by altering my node version to use 0.10 and reverting to v63 of the Heroku Node buildpack (as described in the above issue).

This successfully deploys me a web interface, which can be seen here: https://webmakerpopcorn.herokuapp.com. It can pull media (except youtube, unless I'm misunderstanding something) successfully. However, I cannot seem to login through either a Persona or a username.

In my Heroku error logs I can see:
POST /authenticate 500 11ms - 56b
and
POST /auth/v2/uid-exists 500 4ms - 56b
respectively.

How would one go about successfully deploying on Heroku?

ps, my local.js configuration file: https://gist.github.com/ianseyer/c0022ace57cbf458cd9d