Comments (2)
In addition, I don't know if it's off-topic here and only for web-ext
, but even if we patch the timeout, it might makes sense for web-ext
to return without an error when the timeout has been reached, if the upload is marked as valid
.
It would mean that although it passed linting and basic validation rules, signing has not been done yet, for whatever reason, but is expected to happen eventually.
We already have code that does this for listed uploads, relying on the automated_signing
property returned by AMO API, but that property has been a bit misleading for a while: A lot of uploads are now auto-approved, even listed
, but we still (currently and in the future) return "automated_signing": false
for those.
from sign-addon.
Building on my previous comment, here is how I think it should work from a user perspective:
Validating add-on
pseudo progress bar is marked as finished as soon as polling detectsvalid
istrue
on the upload, otherwise reports an error and terminates the process- If validation was successful a second pseudo progress bar is started,
Signing add-on
- Once
signed
istrue
, everything behaves as before - If timeout is reached, return with the following message:
Your add-on has been submitted for review. It passed but could not be automatically signed, you'll receive an email when it is available for download
and terminate.
from sign-addon.
Related Issues (20)
- Handle `Signing is still pending` better HOT 1
- Update CircleCI docker images
- run CI on node16
- test fails under WSL
- Switch to ES modules
- Expose version in `User-Agent` header when querying the AMO API HOT 3
- Please use Dependabot instead of Renovate
- web-ext sign incorrectly specifies a 24 hour timeframe HOT 1
- Use Jest timer mocks HOT 1
- Release new version HOT 3
- Source code submission HOT 7
- Port travis deploy config to dpl v2
- Cannot import signAddon directly in ES modules on nodejs
- Dependency Dashboard
- Travis CI free usage ends Dec 3; mozilla repos should switch to other CI platforms HOT 1
- Make progress bar optional HOT 24
- Update message for "signing took too long to complete" error HOT 12
- Use new Codecov Uploader
- Review npm deprecation warnings HOT 3
- Use `got` instead of `request` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sign-addon.