GithubHelp home page GithubHelp logo

Comments (2)

diox avatar diox commented on August 16, 2024

In addition, I don't know if it's off-topic here and only for web-ext, but even if we patch the timeout, it might makes sense for web-ext to return without an error when the timeout has been reached, if the upload is marked as valid.

It would mean that although it passed linting and basic validation rules, signing has not been done yet, for whatever reason, but is expected to happen eventually.

We already have code that does this for listed uploads, relying on the automated_signing property returned by AMO API, but that property has been a bit misleading for a while: A lot of uploads are now auto-approved, even listed, but we still (currently and in the future) return "automated_signing": false for those.

from sign-addon.

diox avatar diox commented on August 16, 2024

Building on my previous comment, here is how I think it should work from a user perspective:

  • Validating add-on pseudo progress bar is marked as finished as soon as polling detects valid is true on the upload, otherwise reports an error and terminates the process
  • If validation was successful a second pseudo progress bar is started, Signing add-on
  • Once signed is true, everything behaves as before
  • If timeout is reached, return with the following message: Your add-on has been submitted for review. It passed but could not be automatically signed, you'll receive an email when it is available for download and terminate.

from sign-addon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.