mpickering / refact

Intermediary between ghc-exactprint and hlint

Specify refactorings to apply with apply-refact.

refact's Issues

Add to Stackage

All useful packages and their dependencies should be on Stackage - http://www.stackage.org/. Somewhat of a requirement for HLint to use Refact, since HLint is in Stackage.

refact.cabal: Remove README.md from data-files

Placing README.md and CHANGELOG in data-files is incorrect, as these files aren't required at runtime. They should probably be moved to extra-source-files or extra-doc-files.

Think about making SrcSpan more efficient

The current definition of SrcSpan takes a lot of memory and is quite prone to space leaks. I would expect to see:

data SrcSpan = SrcSpan {startCol :: {-# UNPACK #-} !Int, startLine :: {-# UNPACK #-} !Int, ...}

That definition takes 32 bytes on a 64bit machine and has no space leaks. In contrast, your definition will be more like 80 bytes and highly likely to space leak if someone isn't careful. Perhaps think about switching. In practice, it might not be a bottleneck, and thus might be not so bad.

Add more derivations

Add Data/Typeable to the definitions without exception - they are very handy for SYB style stuff (which HLint does a lot of).

If RType will always be an enum (as it looks plausible) think about also adding Enum and Bounded, which gives you the handy [minBound..maxBound] to loop over all RTypes, but that one is less important, and arguably there's little chance to by polymorphic over the RType, so it might not make sense.