mplatt / fold-to-ascii Goto Github PK

Looking at the source, foldMaintaining only takes 1

I tried the following in Chrome and Firefox.

> ASCIIFolder.fold("🍆", null)
"null"
> ASCIIFolder.fold("こんにちは", null)
"nullnullnullnullnull"
> ASCIIFolder.fold("お早うございます", null)
"nullnullnullnullnullnullnullnull"

According to the docs, all cases should not have performed any character replacements.

Fold is not a function

Last changes introduced in this library, specifically the ones introduced in this commit in particular: 4cf57c7#diff-e9ef0426c130f92ae3cda5a4b3d0356fL32. Must be considered as a breaking change and probably should be managed as a major release of the package. v5.0.0

If I do this:

{ fold } = require('fold-to-ascii'),

I end up with an error that says fold is not a function.

Hi,
fold-to-ascii has been broken in the new version of Typescript 4.4.

Cannot read property '_fold' of undefined

import { foldReplacing } from "fold-to-ascii";
foldReplacing("test string");

Reproduction: https://codesandbox.io/s/fold-to-ascii-typescript-4-4-broken-xxkc4

When I'm using main-bower-files, main file from your library is moved to vendor directory of my project. Index.js doesn't say too much. Please, consider renaming it. I hope it doesn't make big difference for you.

Would it be possible to offer an ES5 version alongside the ES6 version by running it through something like Babel?