Comments (5)
What is the assumed behavior for writeToStream()? Do we assume that whenever we call it, the highwatermark will be hit and subsequently the drain will be called? Or is that a false assumption being made by the aedes code?
Either drain
or error
will be emitted if writeToStream
return false
. There is no need to wait if it returns true
.
What is the best way to check if the call succeeded to write the data to the stream or if it failed?
You don't want to wait for a confirmation that data is written to the stream. It has no real meaning of being actually sent on the wire, just that it has been received by the underlining layer. In fact, sending the data could fail even if the callback is invoked successfully.
The way Aedes does it is correct to achieve maximum throughput on a socket.
from mqtt-packet.
Thanks for the clarification @mcollina.
Follow-up question: What is the rationale behind the design of emitting errors on the passed-in stream outside of the internal stream context? My naive inclination would be that error
should only be emitted internally in the stream context and not from the outside.
For context, I've been discussing with @YoDaMa offline.
from mqtt-packet.
Follow-up question: What is the rationale behind the design of emitting errors on the passed-in stream outside of the internal stream context? My naive inclination would be that error should only be emitted internally in the stream context and not from the outside.
I don't understand the question. Some of the design of Node.js stream does not have a clear rationale, it just happened 🤦♂️😅.
from mqtt-packet.
Sorry my question wasn't clear. In mqtt-packet
, if there is an error then stream.emit('error')
is called. I would think it is bad practice to call emit('error')
on the stream instance because it is not part of the public API of streams and is an internal thing. What is the reason for mqtt-packet
to do this?
Example:
Line 109 in 23774e7
from mqtt-packet.
Oh! I forgot we were doing that in this module. This problem was fixed long ago in Node.js. We should be calling stream.destroy(err)
instead.
Would you like to send a PR?
from mqtt-packet.
Related Issues (20)
- Current Typescript definitions are difficult to use to read userProperties
- stop validating protocol level in this package HOT 1
- can't comply with MQTT spec requirements about flag validation HOT 1
- Generate 'puback' package can't set 'qos' properties HOT 5
- Buffer is not defined HOT 1
- SUBSCRIBE packet with no payload HOT 3
- Cannot connect to some MQTT server when the connect packet sent in chunk instead of full packet at once HOT 1
- Call `stream.destroy(err)` instead of `stream.emit('error', err)` HOT 1
- Cannot specify subscription identifier when sending a SUBSCRIBE packet
- Publish v8.0.0 to NPM
- Are there any usage examples?
- Will mqtt-packet convert date to timestamp?
- numbers.js cache excessive memory usage HOT 2
- Connect packet HOT 1
- Mqtt 5 puback is different from spec HOT 6
- Typescript HOT 4
- Block-scoped declarations (let, const, function, class) not yet supported outside strict mode HOT 3
- Regression in v6.6.0 for parsing multi-byte length header that is split across write calls HOT 5
- Buffer out of bounds when v5 connection request sent to v4 server
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mqtt-packet.