Comments (2)
Thanks Matteo, the comment on endianess makes sense.
Yes, the interface is a little bit different, but wondering if these buffers can be combined somehow into a single buffer object with different views. I have some ideas on how to improve the stream writing, will see if I get some time to hack on it and run some benchmarks.
from mqtt-packet.
Part of the reason we are allocating all those buffers is to avoid creating them at runtime when this information is sent on to the wire. The question is how much writing a slice of this new massive UInt16Array will cost.
I always welcome perf improvemements, so why don't you prepare a PR and we can benchmark? I don't think the logic of what you propose would be identical to what we have here.
(Note that the endianess is required by the MQTT protocol)
from mqtt-packet.
Related Issues (20)
- Current Typescript definitions are difficult to use to read userProperties
- stop validating protocol level in this package HOT 1
- can't comply with MQTT spec requirements about flag validation HOT 1
- Generate 'puback' package can't set 'qos' properties HOT 5
- Buffer is not defined HOT 1
- SUBSCRIBE packet with no payload HOT 3
- Cannot connect to some MQTT server when the connect packet sent in chunk instead of full packet at once HOT 1
- No callback on writeToStream? HOT 5
- Call `stream.destroy(err)` instead of `stream.emit('error', err)` HOT 1
- Cannot specify subscription identifier when sending a SUBSCRIBE packet
- Publish v8.0.0 to NPM
- Are there any usage examples?
- Will mqtt-packet convert date to timestamp?
- Connect packet HOT 1
- Mqtt 5 puback is different from spec HOT 6
- Typescript HOT 4
- Block-scoped declarations (let, const, function, class) not yet supported outside strict mode HOT 3
- Regression in v6.6.0 for parsing multi-byte length header that is split across write calls HOT 5
- Buffer out of bounds when v5 connection request sent to v4 server
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mqtt-packet.