mr-pmillz / pimp-my-shell

go program that installs and customizes ohmyzsh tmux vim via various plugins and other nice to haves

Hi 👋, I'm Phil Miller

I enjoy Cyber Security, Devops Engineering, and Automation

Connect with me:

Languages and Tools:

 

pimp-my-shell's Issues

add cli args to specify what you want installed with a default of all.

So when program is ran with no args, by default it will do a full installation

Can use cobra or mk-ideal cli library.

Cobra will require significant refactoring of the project.

Runtime error index out of range[1] with length 0 when rerunning ./pimp-my-shell

Describe the bug
I had followed the instructions on how to install for mac (git clone, go build --> ./pimp-my-shell) and thought it had installed without any errors. However, in restarting my terminal, nothing loaded. When I try to rerun ./pimp-my-shell I get an error:

goroutine 1 [running]:
github.com/mr-pmillz/pimp-my-shell/zsh.updateZSHPlugins({0xc000032140, 0x1e})
        ~/Downloads/pimp-my-shell/zsh/zsh.go:29 +0x615
github.com/mr-pmillz/pimp-my-shell/zsh.InstallOhMyZsh({0x155b888, 0x6}, 0xc000212d60)
        ~/Downloads/pimp-my-shell/zsh/zsh.go:197 +0x7be
main.pimpMyShell({0x155b888, 0x6}, 0xc000212d60, 0x1?)
        ~Downloads/pimp-my-shell/main.go:73 +0x26a
main.main()

This occurs when attempting to run in a regular iterm2 terminal, but also attempted on a Mac standard install terminal

To Reproduce
Steps to reproduce the behavior:

1. git clone https://github.com/mr-pmillz/pimp-my-shell.git
2. cd pimp-my-shell
3. go build
4. ./pimp-my-shell
5. Let the install process occur. At this point there was no noticeable change to my terminal, even after restart.
6. Attempt to run ./pimp-my-shell again
7. error message

Screenshots

Desktop (please complete the following information):

• Device: Macbook Pro 2018
• OS: MacOS Monterey 12.6.2
• iTerm2 Version: 3.4.18
• Mac Terminal: 2.12.7

Permissions Errors when running `pimp-my-shell`

Describe the bug
I'm required to run as sudo in order to successfully install. If not run as sudo, p10k configure will not run, and error messages appear. Is there any way to install without requiring sudo perms?

To Reproduce
Steps to reproduce the behavior:

1. Download pimp-my-shell v 2.1.3
2. Run ./pimp-my-shell
3. errors appear during install.

Screenshots

First error appears:

Error messages appearing while running the install:

vim-go: gotags not found. Installing github.com/jstemmer/gotags@master to folder
^/usr/local//bin/
vim-go: Error installing github.com/jstemmer/gotags@master: go: writing stat cac
he: mkdir /usr/local/pkg/mod/cache/download/github.com/jstemmer/gotags: permissi
on denied
vim-go: go: downloading github.com/jstemmer/gotags v1.4.2-0.20180202163508-7de70
45e69ff
vim-go: go: github.com/jstemmer/gotags@master: mkdir /usr/local/pkg/mod/cache/do
wnload/github.com/jstemmer/gotags: permission denied
vim-go: impl not found. Installing github.com/josharian/impl@main to folder /usr
/local//bin/
vim-go: Error installing github.com/josharian/impl@main: go: writing stat cache:
 mkdir /usr/local/pkg/mod/cache/download/github.com/josharian/impl: permission d
enied
vim-go: go: downloading github.com/josharian/impl v1.2.1-0.20230412175720-30a6be
b5f7cc
vim-go: go: github.com/josharian/impl@main: mkdir /usr/local/pkg/mod/cache/downl
oad/github.com/josharian/impl: permission denied

Desktop (please complete the following information):

• OS: Ubuntu 22.04.3 LTS jammy
• pimp-my-shell v 2.1.3

ARM64 & AMD64 cases are incorrect - swapped?

ARM64 & AMD64 cases are incorrect - swapped?
For some reason was always DLing the wrong go CPU type - take a look

─────────────────────────────────────────────────────────────────────────────────────────────┐
localio/localio.go:188: func DownloadAndInstallLatestVersionOfGolang(homeDir string) error { │
─────────────────────────────────────────────────────────────────────────────────────────────┘
188⋮ 188│ latestGoVersion := string(goversion)
189⋮ 189│
190⋮ 190│ switch GetCPUType() {
191⋮ │ case "AMD64":
⋮ 191│ case "ARM64":
192⋮ 192│ armGoURL := fmt.Sprintf("https://dl.google.com/go/%s.linux-arm64.tar.gz", latestGoVersion)
193⋮ 193│ dest := fmt.Sprintf("%s/%s", homeDir, path.Base(armGoURL))
194⋮ 194│ if err = DownloadFile(dest, armGoURL); err != nil {

─────────────────────────────────────────────────────────────────────────────────────────────┐
localio/localio.go:199: func DownloadAndInstallLatestVersionOfGolang(homeDir string) error { │
─────────────────────────────────────────────────────────────────────────────────────────────┘
199⋮ 199│ return err
200⋮ 200│ }
201⋮ 201│
202⋮ │ case "ARM64":
⋮ 202│ case "AMD64":
203⋮ 203│ amdGoURL := fmt.Sprintf("https://dl.google.com/go/%s.linux-amd64.tar.gz", latestGoVersion)
204⋮ 204│ dest := fmt.Sprintf("%s/%s", homeDir, path.Base(amdGoURL))
205⋮ 205│ if err = DownloadFile(dest, amdGoURL); err != nil {
(END)