mrchypark / sendgridr

Mail Sender Using SendGrid mail API

this template from https://github.com/EricSeokgon many Thanks!

Devops engineer, Open-source contributor

• I’m a big fan of R & docker working on data-related tasks. I’m interested in research about text.
• I have recently use go language and kubernetes.
• I am more interested in people being able to handle data more easily and eventually to facilitate data-based communication.

Interest

• Open source
• Task automation
• Low code solution

sendgridr's Issues

add daily function work check test

Problems with installation

Having some issues installing the package on an Ubuntu machine with R 3.6.0. Any attempts to install from CRAN/Git on a version higher than 0.5.1 results in this error. I can successfully install 0.5.1 from CRAN archive, but anything above this fails due to a keyring errors. I have tried both removing sendgridr completely, as well as keyring completely

For what it's worth, I do have keyring configured correctly (I can even run an auth_check() and get TRUE from sendgridr), but it still will not let me update. I'd honestly prefer to just use a local environment variable, which I see is a feature in the new version, but I am not able to install that version.

In the meantime, I have downgraded to 0.4.3 which uses the environment variable, but seems like if environment variables are an option, reducing the need for a keyring dependency upon installation would be preferable?

* installing *source* package ‘sendgridr’ ...
** package ‘sendgridr’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** inst
** byte-compile and prepare package for lazy loading
Warning: replacing previous import ‘purrr::pluck’ by ‘rvest::pluck’ when loading ‘emayili’
** help
*** installing help indices
*** copying figures
** building package indices
** testing if installed package can be loaded from temporary location
Warning: replacing previous import ‘purrr::pluck’ by ‘rvest::pluck’ when loading ‘emayili’
Error: package or namespace load failed for ‘sendgridr’:
 .onLoad failed in loadNamespace() for 'sendgridr', details:
  call: b__file_set_keyring_pass(self, private, key, keyring)
  error: Aborted setting keyring password
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/usr/local/lib/R/site-library/sendgridr’
* restoring previous ‘/usr/local/lib/R/site-library/sendgridr’

> sessionInfo()
R version 3.6.0 (2019-04-26)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 16.04.5 LTS

Matrix products: default
BLAS:   /usr/lib/libblas/libblas.so.3.6.0
LAPACK: /usr/lib/lapack/liblapack.so.3.6.0

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
[1] compiler_3.6.0 tools_3.6.0   

limitation of content

Limitation of content

Dear package developer,

Thank you for your nice package!

I am one of your big fan from South Korea !!

I have a problem of your package.

Specifically, it seems to me that there is a limitation of content.

The reproducible example:

library(sendgridr)
body=paste0(1:357,collapse="")
mail() %>% 
     from("[email protected]" ) %>% 
     to("[email protected]") %>% 
     subject("Test") %>% 
     content(body)  %>% 
     send()

Error: [ENAMETOOLONG] Failed to stat '1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563

Please rename content function

The content function can clash with the fairly popular httr::content function. I would recommend either name spacing your functions ie sg_content or thinking of a different name.

Thanks for the wonderful package.

embed_rmd() not work with on non-utf8 env like LC_COLLATE=Korean_Korea.949

when locale is LC_COLLATE=Korean_Korea.949, if Rmd have some non english text, got error when render using emayili::render()

attachments function need to check file path is right

add fs::is_file() to check

[bug]: Email addresses containing dashes are considered invalid

Reprex

library(sendgridr, warn.conflicts = FALSE)

mail() |>
      from("[email protected]") |>
      to("[email protected]") 
#> Error in to(from(mail(), "[email protected]"), "[email protected]"): please check email address.

^{Created on 2024-01-03 with reprex v2.0.2}

Expected behaviour

"[email protected]" should be considered a

library(sendgridr, warn.conflicts = FALSE)

mail() |>
      from("[email protected]") |>
      to("[email protected]") 
#> SendGrid Mail -
#> ✔   from   : [email protected]
#> ✔   to     : cnt[1] [email protected]
#> ✖   subject: (required)
#> ✖   content: (required)
#> ✔   attach : (optional)

Cause

The error is triggered by the function email_chk()

email_chk("[email protected]")
#> [1] TRUE

email_chk("[email protected]")
#> [1] FALSE

Make keyring use optional

I have many shinyapps and jobs where I need to send emails using sendgridr. In the previous versions, I just had to set the SENDGRID_API environment variable to my key, and the function send would get the key from there. In the new release it is not possible any more, and there is the need to use the prompt to type the password to the keyring. I suggest the following: if the user has the envvar SENDGRID_API set, use that; otherwise, use keyring.

I can make a pull request with that, if you wish! I suggest something like this:

send = function(mail) {
  tar <- "https://api.sendgrid.com/v3/mail/send"
  
  key = Sys.getenv("SENDGRID_API")
  if (nchar(key) == 0) key = auth_key()
  
  ahd <- httr::add_headers(Authorization = paste0("Bearer ", key), `content-type` = "application/json")
  body <- jsonlite::toJSON(mail, auto_unbox = TRUE)
  body <- gsub("personalizations\":", "personalizations\":[", 
               body)
  body <- gsub("},\"subject\"", "}],\"subject\"", body)
  res <- httr::POST(tar, ahd, body = body)
  res <- httr::content(res)
  if (identical(res, raw(0))) {
    res <- list(success = "Send Success!")
  }
  return(res)
}

Use sg prefix for autocomplete and prevent potential namespace conflicts

Would you consider using the sg_ prefix for the API as it would bring easy autocompletion and avoid any potential namespace conflicts. Since sendgridr is still in its experimental stage and on a version below 1.0.0, it would be a great opportunity to make this change before it gets more mature.

conflicted::conflict_scout(c("sendgridr", "base", "gmailr", "emayili"))
#> 9 conflicts
#> • `attachment()`: gmailr and emayili
#> • `bcc()`: sendgridr, gmailr, and emayili
#> • `body()`: sendgridr, base, and gmailr
#> • `cc()`: sendgridr, gmailr, and emayili
#> • `from()`: sendgridr, gmailr, and emayili
#> • `local()`: base and emayili
#> • `raw()`: base and emayili
#> • `subject()`: sendgridr, gmailr, and emayili
#> • `to()`: sendgridr, gmailr, and emayili

Thank you for the amazing work!

wait for cran udpate

dependency package(emayili) over 0.7.0 but not on cran now. sendgridr also wait for this.

POLL: how about use https://github.com/datawookie/emayili?

Hi, all!

I have a question.

hardly development package named emayili is also support sendgrid.

how about use https://github.com/datawookie/emayili?

plz response anytime. Thank you all.

img disappear in gmail

img tag is still body without src.

Problem to develop a shinyapp with the sendgrid package

Dear creators,
After asking to hide the kyering package to authenticate myself to the sendgrid api #48.

I tried to develop a shinyapp with the sendgrid dev package installed locally with the following command.

install.packages("sendgridr", repos = "https://mrchypark.r-universe.dev")

but the shiny deploy process, gave me the following error.

Errore: Unhandled Exception: Child Task 1245481735 failed: Error building image: Error fetching sendgridr (0.6.0) source. <CRANPackageSource repo='http://cran.rstudio.org'> unable to satisfy package: sendgridr (0.6.0)
Esecuzione interrotta

How can i solve this?

miss from print

info to readme about r 4.2 windows don't error about non-ascii text with render function

#24

How can I use "new line" in content?

Thanks for your package. I have a question.

I want to use new line in content. But content("aaa\n\naa) dosen't work. How can I use?

need to add dynamic template real send test

.JSON files in attachments() are duplicated in sent email...

Including a file with a .json extension in attachments() duplicates the json file in the sent email. So, if I use this syntax below to send an email, it will have three attachment files (instead of the correct two) in the email I receive: File1.json, File1.json and file2.txt.

mail() %>%
@.") %>%
@.") %>%
subject("See attached files...") %>%
body("Please find attached the files you requested") %>%
attachments("File1.json") %>%
attachments("file2.txt") %>%
send()

remove readme.rmd

just use readme.md for all-contributor

add vignette

rmd send test fail

https://github.com/mrchypark/sendgridr/runs/5958306675?check_suite_focus=true#step:10:29

attachment meme type is not good work

I don't want to handy data table for meme type

"application/xml is recommended as of RFC 7303 (section 4.1), but text/xml is still used sometimes. You can assign a specific MIME type to a file with .xml extension depending on how its contents are meant to be interpreted. For instance, an Atom feed is application/atom+xml, but application/xml serves as a valid default."

readme img resource

Please briefly describe your problem and what output you expect. If you have a question, please don't use this form. Instead, ask on https://stackoverflow.com/ or https://community.rstudio.com/.

Please include a minimal reproducible example (AKA a reprex). If you've never heard of a reprex before, start by reading https://www.tidyverse.org/help/#reprex.

---

Brief description of the problem

# insert reprex here

change to renvron to keyring package

Error: [ENAMETOOLONG] Failed to stat

Hi there, it is weird but I'm still getting an error when trying to send an email with the body that exceeds 200 characters.
I've updated to sendgridr version 0.4.2 on CRAN.
This is the same as #7

Using Templates

Hello, great package!

I'm wondering if there is a clear method to pass dynamic data to a SendGrid template with a template ID? I think that it would use methods outlined here: https://docs.sendgrid.com/ui/sending-email/how-to-send-an-email-with-dynamic-transactional-templates

Using a template may help with an issues with rendering static formatting or images, such as base64 encoding an image or storing the hardcoded HTML.

Plus symbol "+" in to() results in error

If there is a "+" in the to email it will not send and result in an error.

Error in to(., [email protected]): please check email address.

mail() %>% 
from("[email protected]") %>% 
to("[email protected]") %>% 
template_id("1234") %>% 
dynamic_template_data(data) %>% 
body("Hello!") %>%
send()

Error in to(., "[email protected]") : please check email address.

I'm not sure if this is inherent to SendGrid itself.

send() seems to fail without a body specification

I have found that send() seems to fail if there is not body specification in the email object. If this is by design, ok. Just want to point this out in case it is a bug.

This code will not send:
email <- sendgridr::mail()
email <- sendgridr::from(email, "[email protected]", "Mail Sender")
email <- sendgridr::to(email, "[email protected]")
email <- sendgridr::subject(email, "Subject")
sendgridr::send(email)

This code does send successfully:
email <- sendgridr::mail()
email <- sendgridr::from(email, "[email protected]", "Mail Sender")
email <- sendgridr::to(email, "[email protected]")
email <- sendgridr::subject(email, "Subject")
email <- sendgridr::body(email, "Body")
sendgridr::send(email)

Specifying multiple attachments duplicates files...

I like what your sendgridr package does and very easily allows me to send mail via sendgridr. However, it appears that attachments() has a bug when I attempt to send multiple attachments.

For example, this works as expected, and I get one file in my email:
mail() %>%
from("[email protected]") %>%
to("[email protected]") %>%
subject("See attached files...") %>%
body("Please find attached the files you requested") %>%
attachments("File1.docx") %>%
send()

However, if I want to send multiple attachments, I use this:
mail() %>%
from("[email protected]") %>%
to("[email protected]") %>%
subject("See attached files...") %>%
body("Please find attached the files you requested") %>%
attachments("File1.docx") %>%
attachments("File2.xlsx") %>%
attachments("File3.pptx") %>%
send()

It does send the email, but I get two copies of each attachment.

cran issue

https://cran.r-project.org/web/checks/check_results_sendgridr.html

add attachment mime types with mime package

https://github.com/yihui/mime

A thin wrapper for in-lining CSS styles into HTML

https://github.com/noamross/juicer