mrcrayfish / mightymail

A fun and simple mailing system for your world!

i make minecraft mods

mightymail's Issues

Long shutting down times

When running /stop on a server, it takes several minutes (More than 15) and it stops in the line:

[Server thread/INFO] [Framework/]: Sending config unload event for mighty_mail.server.toml

We running on the MM version: 1.0.14
Forge version: 47.1.3

Keybinds activating in Post Box menu prevent typing

Hi! One of my players reported an issue they had while trying to type a message in the Post Box. Every time they typed the letter "e" or "g," it would exit the interface, and the message would be lost. E obviously opens the inventory and G opens the curios slots. Unbinding those keys fixes the issue, but obviously that's not an ideal solution.

This was occurring on a server. I am testing it now in singleplayer, and not having any issues with "e" - but "g" does indeed close the interface.

Let me know if you need any other information! Thank you!

Suggestion/request Surprise in mailboxes

Since you can't see what's inside the packages it could be fun to have items that activate when opening the package such as confetti explosions... or actual ones.
Love the work either way, keep it up!

[Request] Notification of mail

I and my users frequently forget to check our mailboxes.

Maybe you can add something for notification? It’s better to show that the box is not empty.

A system similar to what Contact does, where you receive a chat notification if you're online when you receive mail. Additionally, the snailbox could have a visual indicator when it has mail (in case it arrives when you're offline).

Although, perhaps I have some problems because I don’t see the red flag.

[Suggestion/Request] Postage

Hi. Just wanted to suggest that if you added an option for postage for sending a package, it might balance out mailing packages somewhat. Thanks!

Sound Subtlitle Not Working

Minecraft Version: 1.19,4
Modlaoder: Quilt
Mod version: 1.0.13
Image:
https://media.essential.gg/88446f9f-582b-4d5b-daa5-d3aa2b329600

Crash on i button hover in Post Box [Fabric 1.20.1]

Hello! I didn't technically see this git linked for issues for this mod yet on Curseforge but I'm hoping it's still okay to post my crash here.

This happened both in a heavy modded client, and when loading just this mod, framework, and fabric api. Whenever I hover over the little styled "i" button in the post box item the game crashes to desktop with the error below as the core of the crash report.

I'm putting together a modpack for a small community and this mod would be perfect for us, but I can't chance them crashing the server constantly by just mousing over the wrong thing in the mail. (Even if I warned them. They'd do it anyway. I know they would.)

Thank you!

Framework Version: 0.6.16
Mighty Mail Version: 1.0.8
Fabric API Version: 0.87.0
Fabric Loader Version: 0.14.22
Minecraft Version: 1.20.1

[21:26:52] [Render thread/ERROR]: Reported exception thrown!
net.minecraft.class_148: Rendering screen
	at net.minecraft.class_757.method_3192(class_757.java:954) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1219) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.22.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.22.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.22.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]
Caused by: java.lang.IllegalAccessError: class com.mrcrayfish.mightymail.platform.FabricClientHelper tried to access private field net.minecraft.class_7919.field_41103 (com.mrcrayfish.mightymail.platform.FabricClientHelper and net.minecraft.class_7919 are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @66480dd7)
	at com.mrcrayfish.mightymail.platform.FabricClientHelper.setTooltipCache(FabricClientHelper.java:15) ~[mighty_mail-fabric-1.20.1-1.0.8.jar:?]
	at com.mrcrayfish.mightymail.client.util.ScreenHelper.createMultilineTooltip(ScreenHelper.java:41) ~[mighty_mail-fabric-1.20.1-1.0.8.jar:?]
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_2389(PostBoxScreen.java:208) ~[mighty_mail-fabric-1.20.1-1.0.8.jar:?]
	at net.minecraft.class_465.method_25394(class_465.java:100) ~[client-intermediary.jar:?]
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_25394(PostBoxScreen.java:138) ~[mighty_mail-fabric-1.20.1-1.0.8.jar:?]
	at net.minecraft.class_437.method_47413(class_437.java:110) ~[client-intermediary.jar:?]
	at net.minecraft.class_757.method_3192(class_757.java:945) ~[client-intermediary.jar:?]
	... 9 more
---- Minecraft Crash Report ----
// Who set us up the TNT?
Time: 2023-08-23 21:26:52
Description: Rendering screen
java.lang.IllegalAccessError: class com.mrcrayfish.mightymail.platform.FabricClientHelper tried to access private field net.minecraft.class_7919.field_41103 (com.mrcrayfish.mightymail.platform.FabricClientHelper and net.minecraft.class_7919 are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @66480dd7)
	at com.mrcrayfish.mightymail.platform.FabricClientHelper.setTooltipCache(FabricClientHelper.java:15)
	at com.mrcrayfish.mightymail.client.util.ScreenHelper.createMultilineTooltip(ScreenHelper.java:41)
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_2389(PostBoxScreen.java:208)
	at net.minecraft.class_465.method_25394(class_465.java:100)
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_25394(PostBoxScreen.java:138)
	at net.minecraft.class_437.method_47413(class_437.java:110)
	at net.minecraft.class_757.method_3192(class_757.java:945)
	at net.minecraft.class_310.method_1523(class_310.java:1219)
	at net.minecraft.class_310.method_1514(class_310.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)
A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------
-- Head --
Thread: Render thread
Stacktrace:
	at com.mrcrayfish.mightymail.platform.FabricClientHelper.setTooltipCache(FabricClientHelper.java:15)
	at com.mrcrayfish.mightymail.client.util.ScreenHelper.createMultilineTooltip(ScreenHelper.java:41)
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_2389(PostBoxScreen.java:208)
	at net.minecraft.class_465.method_25394(class_465.java:100)
	at com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen.method_25394(PostBoxScreen.java:138)
	at net.minecraft.class_437.method_47413(class_437.java:110)
-- Screen render details --
Details:
	Screen name: com.mrcrayfish.mightymail.client.gui.screen.PostBoxScreen
	Mouse location: Scaled: (226, 77). Absolute: (680.000000, 233.000000)
	Screen size: Scaled: (534, 300). Absolute: (1600, 900). Scale factor of 3.000000
Stacktrace:
	at net.minecraft.class_757.method_3192(class_757.java:945)
	at net.minecraft.class_310.method_1523(class_310.java:1219)
	at net.minecraft.class_310.method_1514(class_310.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)
-- Affected level --
Details:
	All players: 1 total; [class_746['RhapsPerhaps'/197, l='ClientLevel', x=-2.30, y=73.00, z=-3.31]]
	Chunk stats: 961, 609
	Level dimension: minecraft:overworld
	Level spawn location: World: (0,79,0), Section: (at 0,15,0 in 0,4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
	Level time: 527 game time, 527 day time
	Server brand: fabric
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.class_638.method_8538(class_638.java:458)
	at net.minecraft.class_310.method_1587(class_310.java:2406)
	at net.minecraft.class_310.method_1514(class_310.java:821)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71)

post box isnt linking

so the mail boxes names "post box" it says you can send mail to others on the list (left side of the menu that pops up when you open it) and the list would be people who have the box placed down.. me and two other poeple have them placed down and their names dont pop up.. is this an issue or just being dumb? Thank you!

Mailboxes loses their name after reboot

Hello !

I only tried on singleplayer for a few tests, but the names of the mailboxes disappear after a world restart.

basically, just place down a mailbox, give it a name, leave the world and join back, and the name will disappear.

I am guessing the behavior is the same on a server restart (as that can happen frequently to free some ram), I'm gonna try later today.

[Suggestion/Request] Revision to the rule of no putting containers into mail.

I get that it could cause a lot of lag, and potentially even crashes, to bundle that much data into a single block.

My suggestion for a revision is to allow specifically just packages to be placed into another shipment package.

For some people, shipping 6 items isn't enough. Being able to add up to 6 packages to mail a total of 36 items would be quite nice, especially for roleplay purposes where everyone mails something to a central post office to be forwarded elsewhere, since you could bundle up to 6 packages to a single person into one mail system.

To prevent people from stacking this infinitely, you could add a new package type that is created only when other packages get nested inside. The item could be called "Stacked Packages" and could visually appear as just two boxes tied to one another vertically, but could actually contain up to 6 other packages, or 5 packages and one other item, 4 packages and 2 other items, etc. and would essentially only get created if the mail you're sending contains another regular package.

That'd still be less data than a large chest, and if it proves to continue to overload data when being sent, you could always just store the contained data somewhere else, either in an unused custom sub-dimension with callback references that summon the nested packages upon opening, or just in the mod data - whichever would cause less lag. Other mods often can and do utilize the same techniques, with one example I can think of right off hand being Pepperfly's Sophisticated Backpacks and the Inception Upgrade.

Post box send button overlapping with jei

Send button on the post box overlaps with jei.

Unable to delete names of old players from the list

Hi there!

On a 1.20.1 Fabric server we have a bunch of old names in the list that we're unable to delete. The chunks where their mailboxes were have been reset and those boxes dont physically exist anymore but people's names are still in the list with black icons and "unknown player" tooltip when hovered over.
I've tried removing the mod, restarting the server, joining in then readding the mod back and restarting again... names were still in the list.
Here's a pic:

Is there any way to remove those names? Are they stored somewhere? I couldnt find anything about that in configs.
I can provide more info if needed.
Thanks in advance!

sending multiple pakages dosnt always arive and dissapear.

we didnt need to have the mod too be way too realistic.
idk what causes thyis but something makes it so some pakages sent to a mailbox in succesion causes the newest pakage too dissapear



im using the latest stable version of this mod
with forge 47.2.0
and the 3 pictures above are the mods i have combined.

[Forge 1.19.2] You can bypass the "no cointainers" rule by using a hopper on the postbox (Also works for backpacked)

Heres the vid

https://youtu.be/1QfFTfgRX2Q

Can we hide the names ?

Hello !

I am currently working on an SMP project where we want to add a mailing system.
The issue is that we'd like to be able to send mails anonymously.
Would it be possible to add a feature where the sender can anonymize itself when sending the package ?