knights-on-chessboard python solution is wrong. about the-coding-interview

[mre]

Hi @KarolOlko,
thanks for opening the issue. 😊
Could you open a pull request to fix that?

The letter Y can be a vowel (as in the words "cry", "sky", "fly" , “my” or "why"), or it can be a consonant (as in "yellow", "yacht", "yam" or "yesterday") according to Wikipedia, so I'll leave that up to you.

Cheers!

[KarolOlko]

Sure! niedz., 13.05.2018, 10:25 użytkownik Matthias Endler < [email protected]> napisał:

…

Hi @KarolOlko <https://github.com/KarolOlko>, thanks for opening the issue. 😊 Could you open a pull request to fix that? The letter Y can be a vowel (as in the words "cry", "sky", "fly" , “my” or "why"), or it can be a consonant (as in "yellow", "yacht", "yam" or "yesterday") according to Wikipedia <https://simple.wikipedia.org/wiki/Vowel>, so I'll leave that up to you. Cheers! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AadCn7PGLD0cwH7AfnUw9nyPK9cfeiXzks5tx-32gaJpZM4T8san> .

[mre]

@KarolOlko are you working on a PR? 😉

[mre]

I guess you changed the code in your fork but you simply forgot to create the PR.
That's why I took the freedom to merge it in from your fork.
The fixed version should be in master now.

Thanks for your contribution. 🍸

[KarolOlko]

Thanks! czw., 9 sie 2018 o 23:25 Matthias Endler <[email protected]> napisał(a):

…

Closed #22 <#22>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AadCn25aHA5UtrLZX71BOuMZ8gKjPXNfks5uPKjkgaJpZM4T8san> .

-- Best regards / Pozdrawiam, Karol Olko