mrlegowatch / roleplayingcore Goto Github PK

Migrate JSON reading and writing code to Codable

SimpleDice is a class (reference type) in order to avoid polluting the Dice protocol with a mutable roll() function, that is immutable for most clients. SimpleDice is different because it needs to store intermediate rolls in an Int array, in order to describe them (roll description). For example, "3d4" might produce a roll description of "(3 + 1 + 5)".

I propose changing the roll() function to return a DiceRoll value type, that holds both the result and the roll description, so that the SimpleDice can be a value type.

Pros:

• all Dice implementations are value types

Cons:

• the roll description isn't often required by clients, so represents wasted string "computation"
• clients are now required to extract the result from the DiceRoll

The current requirement for DiceParser is to parse dice strings that are typically specified for hit points, with rolls, modifiers, dropping a throw, and compound dice (multiple dice sub-expressions). The building blocks are there, but the current parser implementation can't handle regular expressions beyond a single compound dice string (e.g., 3d6-2d4 works, but 3d6-2d4+1 does not).

Next steps:

• Decide if a full parser is a requirement (what is the requested feature?)
• Choose the smallest, simplest implementation of a full parser (e.g., leverage RegEx, stick to Foundation types, etc.)

UnitCurrency requires being initialized from load() in order to allow customization for domain-specific currency (D&D 'coinage', space/future 'credits', etc.), but this means that baseUnit() can't return an unwrapped default currency if load() hasn't been called yet. The first loaded currency with a 'default' property wins.

Ideas to consider:

• provide a default unit currency (e.g., "gp") whose symbol etc. can be overridden thru load()
• allow the last loaded currency with a 'default' property to win