GithubHelp home page GithubHelp logo

Comments (20)

mrousavy avatar mrousavy commented on May 12, 2024 3

That error is exactly the same one as in #195, unfortunately I cannot reproduce it. There must be something wrong in the VisionCamera.podspec, maybe the HEADER_SEARCH_PATH for Folly is wrong? Or the .dependency should mention RCT-Folly instead of Folly? I'd appreciate it if you could play around with that and help me get this resolved πŸ™ Maybe use Reanimated's podspec for inspiration

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024 1

Thank you @matheusmatos! Excited to be part of the team. Also thanks for the report, I wouldn't have noticed on my own! Latest beta (2.4.2-beta.9) now includes app.plugin.js in the npm package - please let me know if you find any other issues! feedback helps me getting this beta ready for a stable release faster.

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024 1

Thanks!! This problem is solved, but we have another one now πŸ˜„

Inside src/expo-plugin/withVisionCamera.ts (line 3) the const pkg import is correct, with two parent directories (../../package.json).

When it's compiled, this file exists in lib/commonjs/expo-plugin/withVisionCamera.js and the import doesn't works.

I changed to ../../../package.json (three parent directories) and it works.

Can you help? Thanks!

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024 1

Hi @mrousavy, sorry for the late reply.

In fact, the problem with Folly affects the RN0.63 - the version which Expo 41 and 42 uses.

To make the app plugin works for Expo42 we need to modify the user Podfile.

I agree that it's not a good practice and would be better wait for #195 get fixed.

Maybe an option can be do this only in a "dangerous branch/tag" and not promote to stable version.

I can wait for Expo43 to use it, but I don't know if there is some other users expecting for this now.

In the last case, would be better remove app.plugin.js from master and add some notes in Readme for people searching for Expo support right now.

Thanks for all!

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

Oh yeah that's my bad. The docs are already live, but the stable version (2.4.1) does not support expo yet. You need to use the @beta tag.

from react-native-vision-camera.

seanconrad1 avatar seanconrad1 commented on May 12, 2024

All good. And real quick, where would I put the beta tag at?

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

Oh you just install it like:

npm i react-native-vision-camera@beta

(or yarn) (dunno if that works with expo install, I'm new to expo πŸ˜„)

from react-native-vision-camera.

seanconrad1 avatar seanconrad1 commented on May 12, 2024

Awesome! I appreciate it and the quick response. I'll mess around with it some more

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024

Hi Marc,

It looks like even in the beta version, it's still missing the app.plugin.js file in npm registry.

You can reproduce creating a fresh project and installing with yarn add [email protected]:

Captura de Tela 2021-07-11 aΜ€s 22 10 02

I'm not sure, but maybe it's happening because this file is ignored in .eslintrc.js - and without this file expo can't load the config plugin correctly.

P.S: good luck on your new journey with the Expo team!

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

61cef75

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

@matheusmatos okay, now everything works? on android and iOS? do frame processors work on both platforms?

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024

Hi, in fact, after fixing this import, I'm not able to compile locally using expo run:ios or eas build --local.

I got an error that maybe is related with issue#195:

Captura de Tela 2021-07-12 aΜ€s 13 03 05

I'll try to compile that using EAS Cloud to understand if the problem is my environment.

I come back with more news!!

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024

@mrousavy That last commit will be sent to npm registry?

When I install using github+hash the master doesn't have the lib folder.

Thus, EAS Cloud can't get correct version of the lib.

from react-native-vision-camera.

matheusmatos avatar matheusmatos commented on May 12, 2024

Sure! Let's fix that, it's a pleasure to help.

Can you release a beta-10 with import fix? We can compile using expo infrastructure and test if the problem also happens there.

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

Does it work for you now? @matheusmatos I believe the folly issue should be tracked separately (in #195) so we can close this one here

from react-native-vision-camera.

brunokiafuka avatar brunokiafuka commented on May 12, 2024

Hi @mrousavy, I believe this is also linked to this issue. I am trying to run the lib on my project, I was able to run the expo prebuild, and whenever I try running expo start I get:

Camera: Native Module 'CameraView' was null! Did you run pod install?
at node_modules/react-native-vision-camera/src/Camera.tsx:33:26 in <global>
at node_modules/react-native-vision-camera/src/index.ts:1:0 in <global>
at App.tsx:4:0 in <global>
at index.js:4:0 in <global>
at http://127.0.0.1:19000/index.bundle?platform=ios&dev=true&hot=false&minify=false:119940:3 in global code

Even after running npx pod-install

from react-native-vision-camera.

mrousavy avatar mrousavy commented on May 12, 2024

@brunokiafuka Are you using the latest beta? Expo support is only available in the latest beta, not the current stable release (will promote to stable soon).

from react-native-vision-camera.

brunokiafuka avatar brunokiafuka commented on May 12, 2024

@mrousavy, I am using the stable version. I will try to add the beta version instead.

from react-native-vision-camera.

brunokiafuka avatar brunokiafuka commented on May 12, 2024

I am now on "react-native-vision-camera": "2.4.2-beta.10", and I am also getting the #195 issue when running

expo run:ios

from react-native-vision-camera.

shekharkhedekar avatar shekharkhedekar commented on May 12, 2024

I am now on "react-native-vision-camera": "2.4.2-beta.10", and I am also getting the #195 issue when running

expo run:ios

@brunokiafuka were you able to resolve this? I see the same thing with:

"expo": "^43.0.4",
"react-native-vision-camera": "2.9.4-expo.11",

Wondering if it's because I'm on OSX 10.10.5/XCode 6.1.1 (I know, I know, it's old, trying to avoid buying a new machine). I'm seeing the same error as you, even after expo prebuild && eas build.

@mrousavy do you think my hunch above is correct?

from react-native-vision-camera.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.