mrts / flag-set-cpp Goto Github PK

The sentinel Unicode symbol ‿ (undertie, U+203F) does not currently work with GCC. Consider renaming to _flag_set_size or perhaps simply _

Currently

// Operator that combines two enumeration values into a flag_set.
template <typename T>
std::enable_if_t<std::is_enum<T>::value, flag_set<T>> operator|(const T& lhs, const T& rhs)

adds | support to all enums, including those that don't have the expected special sentinel.

This breaks e.g. Qt Q_DECLARE_METATYPE() macro.

Fix like here: https://github.com/foonathan/type_safe/blob/master/include/type_safe/flag_set.hpp#L24-L26

(See https://codereview.stackexchange.com/a/230360/210777 )

See https://en.cppreference.com/w/cpp/header/bitset.

Consider carefully what is actually useful and what not. Please comment what you would want to see and what to avoid.