mrverrall / go-row Goto Github PK

PM5 transmits an empty HR as 255 rather than 0

Hi, this works really well except the cadence is seventy-something when I'm only at twenty something strokes per minute. I tried changing *3 to *1 in cpm.go, but clearly that isn't the bit I need to change! Can you help please?

It’d be good if the docs showed how you’d install/run this. Not sure what commands would need to be run and how to pair it to a rower?

Not a massive issues as It's an interrupt so you wanted to close anyway, but need to handle this scenario.

2020/06/23 10:30:55 PM5 error: Unresolvable connection error: can't scan: context deadline exceeded
^C2020/06/23 10:30:58 signal received from os: interrupt
panic: close of closed channel

goroutine 1 [running]:
github.com/go-ble/ble/linux/hci/socket.(*Socket).Close(0x1043660, 0x0, 0x0)
/home/pi/go/src/github.com/go-ble/ble/linux/hci/socket/socket.go:148 +0x30
github.com/go-ble/ble/linux/hci.(*HCI).close(0x107c360, 0x0, 0x0, 0x101a03c, 0x101a03c)
/home/pi/go/src/github.com/go-ble/ble/linux/hci/hci.go:327 +0x50
github.com/go-ble/ble/linux/hci.(*HCI).Close(0x107c360, 0x1000194, 0x108d14)
/home/pi/go/src/github.com/go-ble/ble/linux/hci/hci.go:169 +0x2c
github.com/go-ble/ble/linux.(*Device).Stop(0x100eb00, 0x108d0c, 0x10000e0)
/home/pi/go/src/github.com/go-ble/ble/linux/device.go:105 +0x20
github.com/go-ble/ble.Stop(0x1000001, 0x1077f9c)
/home/pi/go/src/github.com/go-ble/ble/gatt.go:52 +0x34
main.unsetBT()
/home/pi/go/src/github.com/mrverrall/go-row-cycle/go-row-cycle.go:65 +0x14
main.main()
/home/pi/go/src/github.com/mrverrall/go-row-cycle/go-row-cycle.go:33 +0x104

Greatly simplify the process of getting started for less technical users.

Not sure if this is my bug or theirs, but the PM5 will not power down automatically as long as there is an active wireless connection, however even if you turn wireless off on the PM5 it will allow go-row-cycle to reconnect.
go-row-cycle implements a 5s cooling off period when a PM5 disconnects, extending this might mitigate against the issue, but would also delay dynamic reconnects if we experience a disconnection mid session.
Need to investigate ways to mitigate against this without compromising user experience.

In-game avatars look weird riding at the usual rowing spm/cadence of ~30. As cadence doesn't impact in-game performance, look to add a command line switch to scale this if desired.

I don't think this is reasonable for power, a watt is a watt.