mrzmyr / angular-google-plus

Angular module which handles the login with the Google+ API

🤫

angular-google-plus's Issues

I keep receiving gapi is not defined error.

I logged in. Closed browser window. And Opened my webapp again and I receive this error.

How to restore the session when the page is refreshed

How can I get the allready logged in user when the page is refreshed?

https://developers.google.com/+/web/signin/session-state

Do not clean the auth response

I want to integrate GooglePlus oAuth into a third party data provider, but to do this I need the full content of the original auth response with the access_token and the expires_in fields.

Why is this library cleaning that out? Please leave it in.

GooglePlus.logout() is not working

GooglePlus.logout() is throwing the error "Cannot read property 'clear' of null"

Not able to fetch all the user related information like (mail di)

not able to fetch mail id of the longeing user please get me some function which will return data with mail id,
right now

GooglePlus.getUser().then(function (user) {
   debugger;
});

function is not returning mail id in some of the user.. but in some cases is working fine.
please update me on that.

Update `main` in package.json

Watch here https://github.com/lischinskiy/angular-google-plus-improvments

Injection error

Hi,

I am trying to use it in my application using browserify, but i am getting following error:

Error: [$injector:modulerr] Failed to instantiate module googleplus due to:
Error: [$injector:nomod] Module 'googleplus' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument

I have installed it in local and global.

thank you

Is it a good idea to use client secret in front end JavaScript code?

According to this article (https://aaronparecki.com/2012/07/29/2/oauth2-simplified), the client secret must be kept confidential. If a deployed app cannot keep the secret confidential, such as Javascript or native apps, then the secret is not used. However, in this application, we need to use API_KEY in the javascript. Is it actually a good idea? Would it lead to security issues?

I should be able to access refresh token

When creating an offline authorization request I'm not able to access the refresh_token.

google user email info.

Is there any way to get the user's E-mail using this module?

I add 'getEmail' function which does following..
gapi.client.request({path:"plus/v1/people/me"}).execute(function (res) { ... };
and use this scope : "https://www.googleapis.com/auth/plus.profile.emails.read"

Anyone know another way without modifying existing source.?

Set Language

Is it possible to set the language? I have an American traveling in Thailand who's testing my site, but the login prompt is displaying in Thai. It seems like Google automatically bases the language on location/IP address rather than what's set in the browser / computer. If he applies &hl=en to the end of the sign-in popup's URL, it shows up in English. Basically, I'd like to be able to pass the hl value based on what I detect as the users language.

Anyone know why Google does this? If a potential American user is on vacation in Mexico, they'll see the consent form in Spanish rather than English. There must be a reason they do this, but I don't know why.

Get extra fields like placesLived or birthday

According to the documentation (here), how i can find the following informations : placesLived and birthday ?
Because when I set the scope : https://www.googleapis.com/auth/plus.me

GooglePlusProvider.setScopes('profile email https://www.googleapis.com/auth/plus.me');

The response data of getUser() returns me basic informations without extra ...

I there any way to check if user is already authorized or not?

Currently I only changed your checkAuth function to the following (added $q):

NgGooglePlus.prototype.checkAuth = function() {
    deferred  = $q.defer();

    gapi.auth.authorize({
        client_id: options.clientId,
        scope: options.scopes,
        immediate: true
    }, this.handleAuthResult);

    return deferred.promise;
};

So when the user is loaded my app, I can check in angular run function if the user is already authorized or not:

var checkGoogleReady = $rootScope.$watch(function() {
    if(typeof gapi === 'object' && typeof gapi.auth === 'object') {
        console.log('Google API is loaded');
        checkGoogleReady(); // clear watcher

        GooglePlus.checkAuth().then(function () {
            console.log('User is already authorized');
        }).catch(function () {
            console.log('User is not authorized');
        });
    }
});

Do you have better solution for this? Can you extend your module to check if user is already authorized or not?

logout seems not to function

GooglePlus.logout() seems not to have significant effect as next time I execute .login, no username/password is asked.
Repro:

1. login. dialog asks for username/password
2. logout.
3. login: client logs in automatically without asking credentials.

How can i use in Angular 2 apps

I want to use Google plus login in my angular 2 app.. So anyone can help me out please 😄

angular-google-plus improperly deals with logging out of Gmail

Tested in Firefox and Safari.

Procedure to replicate:

1. Log into an account in Gmail.

2. Log into an app using angular-google-plus

3. Log out of that app.

4. Log out of Gmail

5. Attempt to log back into the app.

The app will log you in, but the window to log into a Gmail account will still appear. If an attempt is made to log in using this window, future log-ins will fail until the browser is restarted. Similarly, restarting the browser at any time after step 4 will resolve the issue.

Not able to get email address

Can you please bump the angular dependency version to 1.3.13 or newer

Only load the google client.js script if gapi is undefined

We found that incorporating this module significantly slowed down our Angular 1.5 karma-jasmine tests. Since the run block of angular modules are automatically executed for every test we found that the google client.js was repeatedly inserted and loaded and this slowed down the tests. This duplicate client loading could be avoided if the angular-google-plus run function would check to see if gapi was already loaded before proceeding with the google client script insertion.

Make response Omniauth like

Like this:

{
  :provider => 'facebook',
  :uid => '1234567',
  :info => {
    :nickname => 'jbloggs',
    :email => '[email protected]',
    :name => 'Joe Bloggs',
    :first_name => 'Joe',
    :last_name => 'Bloggs',
    :image => 'http://graph.facebook.com/1234567/picture?type=square',
    :urls => { :Facebook => 'http://www.facebook.com/jbloggs' },
    :location => 'Palo Alto, California',
    :verified => true
  }
}

Cause in previous commits you removed useful info like name or link.

Options global variable must be inside module definition

The definition of the options object that will contains the information of keys and scopes should be placed inside the module.

Actual:

/**
 * Options object available for module
 * options/services definition.
 * @type {Object}
 */
var options = {};

/**
 * googleplus module
 */
angular.module('googleplus', []).

  /**
   * GooglePlus provider
   */
  provider('GooglePlus', [function() {

Must be changed to

/**
 * googleplus module
 */
angular.module('googleplus', []).

  /**
   * GooglePlus provider
   */
  provider('GooglePlus', [function() {
/**
 * Options object available for module
 * options/services definition.
 * @type {Object}
 */
var options = {};

This will prevent any collision of the variable options when use several libraries in your application.

signout causes error

There seems to be a bug in the signout function.

The " return deferred.promise;" is causing "Cannot read property 'promise' of undefined".

OAuth fails after application times out

After an hour of inactivity, my app times out and returns the user to the log-in page. If, here, the user attempts to use the google+ sign-in, they receive back an error code 401, with a message of 'Invalid Credentials'. If the time at which the app times out is shortened (to, for instance, 10 seconds), then in that case, the google+ sign-in appears to work fine.

promise is cached so logging in after failed attempt returns auto-fail

First off, great app.

The one issues,

*) First, I purposely cause a failure by clicking CANCEL on the Google Popup. The promise is resolved correctly as reject / error

*) The second time I login to Google, I accept. Expected result is success, token and my user data. Result is error.

*) logging in a second time causes successful result.

*) Reversing my sequence, Succeeding and then failing causes a similar problem (promise resolves to give me old Auth Token and my data)

Stepping through, I found on second run the promise is instantly resolved without waiting for Google. This seems to be a case Angular Promises being cached. This is particularly interesting since the promise IS correctly bound when Google returns it. It just doesn't wait for the response so I get the cached answer.

I know how to turn off caching when using the $http service, but I don't know how to do so with the $q service.

Bower Version Appears Different

The version being pulled from Bower is marked 0.1.2, but the files appear different. I noticed this issue when I tried to use the server side sign-in support.