msaraiva / exsamples Goto Github PK

View Code? Open in Web Editor NEW

121.0 121.0 8.0 32 KB

Initializes lists of maps, structs or keyword lists using tabular data in Elixir

License: MIT License

Elixir 100.00%

exsamples's People

Contributors

Stargazers

Watchers

Forkers

liveforeverx maxnordlund linearregression vonhabsi fortesinformatica tiagoefmoraes malian

exsamples's Issues

Long table is not formatted properly

The following code:

      samples do
        :id | :name | :currency | :language | :population | :inflation | :continent | :main_sport | :independence_day
        1 | "Brazil" | "Real (BRL)" | "Portuguese" | 204451000 | 7.70 | "South America" | "Football" | ~D["1822-09-07"]
      end

is formatted like this:

      samples do
        :id |            :name | :currency | :language | :population | :inflation | :continent | :main_sport | :independence_day
           
          1
            |         "Brazil"
            |     "Real (BRL)"
            |     "Portuguese"
            |      204_451_000
            |             7.70
            |  "South America"
            |       "Football"
            | ~D["1822-09-07"]
      end

Here is a test that reproduce the error

  test "very long table" do
    code = """
    samples do
      :id | :name | :currency | :language | :population | :inflation | :continent | :main_sport | :independence_day
      1 | "Brazil" | "Real (BRL)" | "Portuguese" | 204451000 | 7.70 | "South America" | "Football" | ~D["1822-09-07"]
    end
    """

    assert Samples.FormatterPlugin.format(code, []) == """
           samples do
             :id | :name    | :currency    | :language    | :population | :inflation | :continent      | :main_sport | :independence_day
               1 | "Brazil" | "Real (BRL)" | "Portuguese" | 204_451_000 |       7.70 | "South America" | "Football"  | ~D["1822-09-07"]
           end
           """
  end

I am suspecting the line_length to be the cause of this behaviour.

I believe we should override the line_length to properly render the table. WDYT? ping @msaraiva

Feature request: binary keys for maps

I am using this stuff to functionally test api endpoints, and keys there are always strings and not atoms.

Right now I have to Enum.into every sample I use.

Trailing white-space are added after comments in the middle of a table

Formatting the following code

samples do
      :fuel_type | :co2 | :year | :percentage
      # 2020
      :diesel    |  105 |  2020 |       0.069
end

Will result in:

samples do
      :fuel_type | :co2 | :year | :percentage
      # 2020----
      :diesel    |  105 |  2020 |       0.069
end

WIth 4 whitespaces after # 2020. I represented them with -

Here is a test that reproduces the bug:

  test "handle comments" do
    code = """
    samples do
      :fuel_type | :co2 | :year | :percentage
      # 2020
      :diesel | 105 | 2020 | 0.069
      :petrol | 110 | 2020 | 0.054
    end
    """

    assert Samples.FormatterPlugin.format(code, []) == """
           samples do
             :fuel_type | :co2 | :year | :percentage
             # 2020
             :diesel    |  105 |  2020 |       0.069
             :petrol    |  110 |  2020 |       0.054
           end
           """
  end

This is due to the offset we add to the first column

exsamples/lib/formatter_plugin.ex

Lines 122 to 124 in 3722216

 {col_index, value} -> 

 offset = if col_index == 0, do: String.duplicate(" ", column_offset), else: "" 

 offset <> align_value(value, cols_info[col_index], false)

A solution could be to pattern match on # in the walk function.

msaraiva / exsamples Goto Github PK

exsamples's People

Contributors

Stargazers

Watchers

Forkers

exsamples's Issues

Long table is not formatted properly

Feature request: binary keys for maps

Trailing white-space are added after comments in the middle of a table

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs

	{col_index, value} ->
	offset = if col_index == 0, do: String.duplicate(" ", column_offset), else: ""
	offset <> align_value(value, cols_info[col_index], false)