GithubHelp home page GithubHelp logo

Windows support about krotodc HOT 6 CLOSED

ymarco avatar ymarco commented on June 12, 2024
Windows support

from krotodc.

Comments (6)

mscheong01 avatar mscheong01 commented on June 12, 2024

It clearly does seem like an issue 😓
tbh, I've never used, or considered Windows in the process of developing this library.
I'll take a look at other kotlin code generation libraries and find out what I should do to solve this.
Thanks for the report! 🙇‍♂️

from krotodc.

mscheong01 avatar mscheong01 commented on June 12, 2024

I'm having trouble getting to the cause of this issue because I don't have a viable windows environment around me that I could debug this with. I think it will take me a few weeks to get this fixed 😢
One thing I noticed from other codegen libraries is that they don't seem to use different line separators 🤔. kotlinpoet also uses "\n" as a linebreaker, and it's hard to think that they haven't considered Windows so there might be a chance that the setup in which you ran the test may have something to do with it.
i'll keep this thread updated on my progress and feel free to help me while I'm at it.

from krotodc.

ymarco avatar ymarco commented on June 12, 2024

so there might be a chance that the setup in which you ran the test may have something to do with it.

I'll try to run it in another windows machine on the weekend

from krotodc.

ymarco avatar ymarco commented on June 12, 2024

Yep, I get the same output on another laptop with freshly-installed java and protoc.

from krotodc.

mscheong01 avatar mscheong01 commented on June 12, 2024

@ymarco, thank you for verifying it again 🙇‍♂️. I plan to get my hands on a Windows computer this weekend and hope to fix the issue soon.

from krotodc.

mscheong01 avatar mscheong01 commented on June 12, 2024

Hi @ymarco 👋
I recently had the opportunity to debug this issue on a Windows system and identified a solution. Simply include @ECHO OFF in your .cmd file, like this:

:: run-krotoDC.cmd
@ECHO OFF
java -jar protoc-gen-krotodc-1.0.1-jdk8.jar %*

I discovered this fix by examining how the protobuf-gradle-plugin executes the plugins (link).
As it turns out, the parsing error was not related to line separators, but rather caused by echoed commands.
Please let me know if this resolves the issue for you. If the problem persists, feel free to reopen this issue so I can address it further.

from krotodc.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.