GithubHelp home page GithubHelp logo

Comments (2)

mscheong01 avatar mscheong01 commented on June 1, 2024

Hi, thanks for the detailed explanations!

  1. oneof names
    I'm aware with issues that can arise from oneof names, which was also reported in #4. However, I'm still considering whether these cases should be handled. As you mentioned, this kind of proto definitions are against the basic conventions and will not likely be used. If we decide to take care of this, I think the solution will be to change the oneof sealed class names to ~Oneof (although it is breaking change)
  2. special field name like xx_2nd -> I was not aware of this issue. I'll look into your PR soon!

from krotodc.

blackhuman avatar blackhuman commented on June 1, 2024

Regarding point 1, while it is certainly a significant matter, I cannot recall any instances where the oneof field name generated by protobuf-java was directly referenced in actual code. From what I understand, the existence of the 'tagCode' field (as seen in the example above) is primarily intended to ensure successful compilation. Since my knowledge of protobuf is limited, I cannot say for certain whether this implementation would disrupt existing code.

from krotodc.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.