msftrncs / pwshjsontoplist

Generate PList XML with PowerShell, Convert tmLanguage.JSON to PList

** Work In Progress **

• 👋 Hi, I’m @msftrncs (or Carl Morris)
• 👀 I’m interested in ...
  • PowerShell
  • Regular Expressions
  • IEC 61131-3
  • TextMate Grammars
  • Databases
• 🌱 I’m currently learning ...
  • Old tricks
• 💞️ I’m looking to collaborate on ...
• 📫 How to reach me ...

pwshjsontoplist's Issues

Consider using local scope for PowerShell Core built in variables to prevent spoofing on Windows PowerShell

PwshJSONtoPList/ConvertTo-PList.ps1

Line 215 in 9f58ba8

) -join $(if (-not $Compress) { "$(if (-not $IsCoreCLR -or $IsWindows) { "`r" })`n" })

For instance, add local: to the use of $IsCoreCLR and $IsWindows, as they do not exist on Windows PowerShell, but could have been defined in a parent scope, possibly unrelated to the PowerShell Core implementation of the built in version of these variables.

Improve ConvertTo-PList function with pipeline input, help documentation, specifying the final encoding, and more

Improve the ConvertTo-PList function with the following:

• Accept objects from the pipeline, by value
• provide comment based help documentation
• provide parameter to specify the final encoding to be stated in the XML header
• provide a parameter to specify if the first (root) object (usually <dict> or <array>) will be indented. Samples of XML PList files generally show the first object not indented, but a generic XML writer usually will indent the first object because its a child object from the <plist> root object of the XML document.
• support more character escapes for <string> characters not supported directly in an XML document.
• Add a test using a sample script, comparing the output to a prepared result.
• Add a Depth parameter to control recursion loops.
• Add support for HashTables with blank keys.

Split away PowerShell.tmLanguage.JSON specific conversion, make ConvertTo-PList function the focus of this repository

I plan to split away the part of 'ConvertTo-Plist.ps1' that deals with converting a 'PowerShell.tmLanguage.json' to the PowerShell.tmLanguage repository as 'build_plist.ps1' so that this repository can focus on just the conversion of a PowerShell object to PList XML.

<data> Tag changed to <String>

Tag changed to

For example:
before:
Find
<data>SEVDSQ==</data>
Replace
<data>SU1FSQ==</data>

---

after:
Find
<string>SEVDSQ==</string>
Replace
<string>SU1FSQ==</string>

See Pic:

My programming level, English expression is not very good,

so, I recorded a video demonstration: https://www60.zippyshare.com/v/72znRFfX/file.html

Related documents: https://www60.zippyshare.com/v/JX5BgvUh/file.html

It may be the same as the following question
msftrncs/PwshReadXmlPList#4

An array input from the pipeline may only have last element serialized.

For example:

[byte[]](1..100) | ConvertTo-Plist # specifically no wrapping comma

will only output (instead of a <data> block with the encoded array):

<integer>100</integer>

Condense `<DATA>` when less than one line of data results

As an enhancement that might relate to examples of PList files, consider condensing the <DATA> output when the result is less than one line anyway.

Empty properties could use `<element/>` syntax

Consider that empty properties could use the XML <element/> syntax. This would primarily affect:

• <dict>
• <array>

But it could also affect:

• <string>
• <data>

I am not sure if there is some guidelines on this behavior.

Reference issue #7

Consistently use `!` or `-not`

(this is just one example)

PwshJSONtoPList/ConvertTo-PList.ps1

Line 190 in 9f58ba8

if (!$Compress) {

PwshJSONtoPList/ConvertTo-PList.ps1

Line 215 in 9f58ba8

) -join $(if (-not $Compress) { "$(if (-not $IsCoreCLR -or $IsWindows) { "`r" })`n" })

Use either ! or -not consistently.

Preferring -not as it is more clear and consistent with the other PowerShell logical operators.

Enumerations incorrectly appear as property name in `<integer></integer>`

For instance:

[flags()] enum WineSweetness : byte { # requires PS 6.2
    VeryDry
    Dry
    Moderate
    Sweet
    VerySweet
}
[WineSweetness]::Moderate | ConvertTo-Plist

Will result in an output of:

<integer>Moderate</integer>

But it should be either:

<integer>2</integer>

or

<string>Moderate</string>

The original format has changed

test file:
Config.zip

---

befor:

<string></string>  

after:

				<dict>
				</dict>

---

2. One line becomes two lines:

befor:

				<key>Name</key>
				<string>IONVMeFamily</string>
				<key>Find</key>
				<data>
				BgIAAEyNuAAQAABMiflIgeEA8P//SYmGGgEAAEmJjiIBAABBvAAQAABJKfQ=
				</data>
				<key>Replace</key>
				<data>
				BgIAAEyNuAACAABMiflIgeEA8P//SYmGGgEAAEmJjiIBAABBvAACAABJKfQ=
				</data>

after:

				<key>Name</key>
				<string>IONVMeFamily</string>
				<key>Find</key>
				<data>
					BgIAAEyNuAAQAABMiflIgeEA8P//SYmGGgEAAEmJjiIB
					AABBvAAQAABJKfQ=
				</data>
				<key>Replace</key>
				<data>
					BgIAAEyNuAACAABMiflIgeEA8P//SYmGGgEAAEmJjiIB
					AABBvAACAABJKfQ=
				</data>