mshroyer / nulltty Goto Github PK

Running the configure script with the --enable-debug argument doesn't result in -g3 being added to CFLAGS, when building with GCC on FreeBSD 9.0.

The relay main loop should test for the termination flag before calling select, and should use pselect with an appropriate signal mask in order to avoid race conditions.

On OpenBSD 5.2 amd64, the "make check" test program hangs indefinitely when attempting to send and verify a message of 1024 bytes. The debug output from the nulltty child process shows it reading and writing exactly 1024 bytes, but the client process only reports reading 1022 from the corresponding file descriptor.

"Error opening requested PTYs: Invalid argument"

It is possible for read/write to block even after select on some systems, e.g. writing to a pseudoterminal master on OpenBSD. This may require some preprocessor trickery in order to work around OS X's issues specifying O_NONBLOCK to a pty.

Provide an option to log relayed data to a pcap file. If this is implemented using libpcap, then a compile-time option should be offered in order to avoid a hard dependency on a third-party library.

Add a simple unit test target to verify that the pseudoterminal relay actually works on this host, by running nulltty as a child process and verifying that data is piped successfully thorough its pty slaves.