mtdowling / git-rook Goto Github PK

running make test before adding to my path produced the following 2 errors.

 ✗ can install hooks to current repo
   (in test file test/git-rook.bats, line 41)
     `[ $status -eq 0 ]' failed
   Initialized empty Git repository in /private/var/folders/b5/4344qh3518nf3dp58nnphd8r0000gn/T/test-repo/.git/
   /Users/masukomi/workspace/reference/bash/git-rook
   /Users/masukomi/workspace/reference/bash/git-rook
 ✗ can install hooks to specific repo
   (in test file test/git-rook.bats, line 50)
     `[ $status -eq 0 ]' failed
   Initialized empty Git repository in /private/var/folders/b5/4344qh3518nf3dp58nnphd8r0000gn/T/test-repo/.git/
   /Users/masukomi/workspace/reference/bash/git-rook
   /Users/masukomi/workspace/reference/bash/git-rook

The problem is a result of this section in install_hook

if [ -f "${dest}" ]; then
    [ "${FORCE}" -eq 0 ] && fail "${dest} exists (use -f to force)" && exit 1
    echo " ! Overwriting ${dest}"
  fi

If your git template directory has any hooks in it already, then running git init will copy those down into the current repo. Obviously the intersection of these two things isn't the greatest use-case. I think the solution is to have git-rook's initialize functionality check if there is a git template directory specified via any of the 3 ways specified in the docs, and if so, check if there are any hooks in it.

Then the question is, should git-rook bail? or should it remove / replace those files that were copied over from the templates directory?

Another solution might be to always move existing files and throw up a notice. So, for example, if there's a pre-commit file there already it'd be renamed something like pre-commit.rook-bak