mtiller / fmusdk Goto Github PK

Remove various print statements currently in the Linux port.

Hi,
I've been fiddling with your lib to build an own co-simulation FMU, and I just realized that things get messy when mixing different kinds of variables in the same model.

A thing that I've assumed this far is that a value reference is unique throughout the model, no matter what type the variable it is referencing. (Correct me here if I'm wrong.)

That said, I think the in-memory storage mechanism for model variables needs to be modified.
Let's say I have 1 real and 1 integer to store. This is how the storage is allocated:

comp->r = calloc(NUMBER_OF_REALS,    sizeof(fmiReal));
comp->i = calloc(NUMBER_OF_INTEGERS, sizeof(fmiInteger));

...where each of those macros are defined to be 1.
I naturally pick the value references to 0 and 1 for my two variables. When trying to set the value of the variable with value reference = 1, I get "fmiSetInteger: Illegal value reference 1", This is because we can't store the integer at the second position in the allocated array of length 1:

comp->i[vr[i]] = value[i]; // vr[i] == 1

I find this inconsistent.

Thanks for all your great work.
Stefan

There have been reports that the temp dir is not getting removed after simulation (in the Linux port at least).

I guess this needs ab update after release of fmusdk vs. 2.