mundialis / grass-gis-helpers Goto Github PK

Possible content:

• check-addon-installation
• general-cleanup ✔️
• parallelization-worker-functions
• ...

I think the logic of using rm_groups (remove groups AND rasters in groups) and rm_groups_wo_rasters (remove groups only, keep rasters) of cleanup.general_cleanup() should be swapped to rm_groups (remove groups only, keep rasters) and rm_groups_with_rasters (remove groups AND rasters).

By default one would assume that rm_groups calls g.remove type=group ...

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Relevant here: https://github.com/mundialis/grass-gis-helpers/blob/main/src/grass_gis_helpers/cleanup.py#L27

From stackoverflow:

Sometimes it seems natural to have a default parameter which is an empty list. However, Python produces unexpected behavior in these situations.

Use

def general_cleanup(
    rm_rasters=None,
    rm_vectors=None,
    rm_files=None,
    rm_dirs=None,
    rm_groups=None,
    rm_groups_wo_rasters=None,
    rm_regions=None,
    rm_strds=None,
    orig_region=None,
    rm_mask=False,
):

instead and add tests if the arguments are not None and a list.